[PR #23626] [MERGED] fix: prevent first-user admin race in LDAP and OAuth registration #66141

New Issue

GiteaMirror · 2026-05-06T12:18:11-05:00

GiteaMirror commented

2026-05-06 12:18:11 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23626
Author: @Classic298
Created: 4/12/2026
Status: ✅ Merged
Merged: 4/12/2026
Merged by: @tjbck

Base: dev ← Head: fix/first-user-admin-race

📝 Commits (1)

7ae8b0b fix: prevent first-user admin race in LDAP and OAuth registration

📊 Changes

2 files changed (+25 additions, -6 deletions)

View changed files

📝 backend/open_webui/routers/auths.py (+9 -3)
📝 backend/open_webui/utils/oauth.py (+16 -3)

📄 Description

Both LDAP and OAuth registration checked user count before insert to determine whether to assign admin role. With multiple workers, concurrent first-user registrations could each see zero users and both create admin accounts.

Applies the insert-first-check-after pattern already used by signup_handler: insert with DEFAULT_USER_ROLE, then atomically check get_num_users()==1 and promote only the sole user to admin.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23626 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 4/12/2026 **Status:** ✅ Merged **Merged:** 4/12/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/first-user-admin-race` --- ### 📝 Commits (1) - [`7ae8b0b`](https://github.com/open-webui/open-webui/commit/7ae8b0b9a2c598a137866678c86667822924dc00) fix: prevent first-user admin race in LDAP and OAuth registration ### 📊 Changes **2 files changed** (+25 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/auths.py` (+9 -3) 📝 `backend/open_webui/utils/oauth.py` (+16 -3) </details> ### 📄 Description Both LDAP and OAuth registration checked user count before insert to determine whether to assign admin role. With multiple workers, concurrent first-user registrations could each see zero users and both create admin accounts. Applies the insert-first-check-after pattern already used by signup_handler: insert with DEFAULT_USER_ROLE, then atomically check get_num_users()==1 and promote only the sole user to admin. ### Contributor License Agreement  - [X] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-06 12:18:11 -05:00

GiteaMirror closed this issue

2026-05-06 12:18:14 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#66141