[PR #23624] [CLOSED] fix: enforce write permission on ydoc document updates #66139

New Issue

GiteaMirror · 2026-05-06T12:17:57-05:00

GiteaMirror commented

2026-05-06 12:17:57 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23624
Author: @Classic298
Created: 4/12/2026
Status: ❌ Closed

Base: dev ← Head: fix/ydoc-write-permission-check

📝 Commits (2)

402a033 fix: enforce write permission on ydoc document updates
71d2bb4 merge: resolve conflicts with upstream async DB migration

📊 Changes

2 files changed (+106 additions, -23 deletions)

View changed files

📝 backend/open_webui/main.py (+2 -0)
📝 backend/open_webui/socket/main.py (+104 -23)

📄 Description

The ydoc:document:update handler only checked room membership, which read-only users satisfy via ydoc:document:join. This allowed read-only users to persist and broadcast Yjs updates to shared notes. Adds a write permission check before any update is stored or broadcast.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23624 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 4/12/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/ydoc-write-permission-check` --- ### 📝 Commits (2) - [`402a033`](https://github.com/open-webui/open-webui/commit/402a0334a930a49fd62616a5661ae73c773b2488) fix: enforce write permission on ydoc document updates - [`71d2bb4`](https://github.com/open-webui/open-webui/commit/71d2bb4fdbca6aadba930771abb287e86b74b924) merge: resolve conflicts with upstream async DB migration ### 📊 Changes **2 files changed** (+106 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/main.py` (+2 -0) 📝 `backend/open_webui/socket/main.py` (+104 -23) </details> ### 📄 Description The ydoc:document:update handler only checked room membership, which read-only users satisfy via ydoc:document:join. This allowed read-only users to persist and broadcast Yjs updates to shared notes. Adds a write permission check before any update is stored or broadcast. ### Contributor License Agreement  - [X] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-06 12:17:57 -05:00

GiteaMirror closed this issue

2026-05-06 12:18:00 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#66139