github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-07 03:18:23 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #23504] [CLOSED] fix(ratingdata): add validator for model rating, forcing the value to be between 1 and 10 #66079

New Issue
Closed
opened 2026-05-06 12:11:46 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-06 12:11:46 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23504
Author: @lorenzophys
Created: 4/8/2026
Status: ❌ Closed

Base: dev ← Head: feedback-validation

📝 Commits (2)

  • e657c91 fix(ratingdata): add validator for model rating, forcing the value to be between 1 and 10
  • e5cc7cf exclude everything that's not a number

📊 Changes

1 file changed (+13 additions, -1 deletions)

View changed files

📝 backend/open_webui/models/feedbacks.py (+13 -1)

📄 Description

Description

Problem: when giving a numeric feedback to a model, a user can skew the statistic by sending a manual request with an arbitrarily positive or negative number.
The backend should always validate inputs at the system boundary regardless of how unlikely abuse is. This was flagged by internal QA during a pentest as a medium severity finding.

Solution: I added some validation to force the numeric feedback between 1 and 10.

Note:

  • If the feedback is a negative number, it's registered as 1.
  • If it's a number greater than 10, it's registered as 10.
  • If it's anything else, the details field is empty

Added

  • Added a details field to RatingData: it reflects what the json object actually is when a rating is applied
  • Added a validator that cap the rating between 1 and 10

Breaking Changes

  • None: this change has no effect other that adding a "details": null to the record if no rating is provided.

Test

Before

  1. Start a new chat
  2. Say "hello"
  3. Click thumbs up or down and select rating
  4. Click send
  5. Intercept the request
  6. Copy json, change the details
  7. Use curl to send the changed payload
curl -XPOST  --header "Content-Type: application/json" --header "Authorization: Bearer xxx" 'http://localhost:8080/api/v1/evaluations/feedback/947a071b-269f-4e91-a245-902ab840fd68' -d @rating.json

where the rating.json has for example

"data": {
    "rating": 1,
    "tags": ["General"],
    "reason": "",
    "comment": "",
    "details": { "rating": -1000 },
    "model_id": "gemma4:31b-cloud"
  },

and you can read in the response

"data": {
    "rating": 1,
    "model_id": "gemma4:31b-cloud",
    "sibling_model_ids": null,
    "reason": "",
    "comment": "",
    "tags": ["General"],
    "details": { "rating": -1000 }
  }

and you get

image

After

Do the same thing, but this time

"data": {
    "rating": 1,
    "tags": ["General"],
    "reason": "",
    "comment": "",
    "details": { "rating": 12345 },
    "model_id": "gemma4:31b-cloud"
  }

results in

"details":{"rating":10}

and

"data": {
    "rating": 1,
    "tags": ["General"],
    "reason": "",
    "comment": "",
    "details": { "rating": -12345 },
    "model_id": "gemma4:31b-cloud"
  }

"details":{"rating":1}
Screenshot 2026-04-08 at 12 13 42 Screenshot 2026-04-08 at 12 12 19

If I pass a string

"data": {
    "rating": 1,
    "tags": ["General"],
    "reason": "",
    "comment": "",
    "details": { "rating": "geiwffwegfu" },
    "model_id": "gemma4:31b-cloud"
  }

I get

"data": {
    "rating": 1,
    "tags": ["General"],
    "reason": "",
    "comment": "",
    "details": {},
    "model_id": "gemma4:31b-cloud"
  }

and in the UI I have

image

Contributor License Agreement

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23504 **Author:** [@lorenzophys](https://github.com/lorenzophys) **Created:** 4/8/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `feedback-validation` --- ### 📝 Commits (2) - [`e657c91`](https://github.com/open-webui/open-webui/commit/e657c9106e79804aa9d448e758d48d9010b06871) fix(ratingdata): add validator for model rating, forcing the value to be between 1 and 10 - [`e5cc7cf`](https://github.com/open-webui/open-webui/commit/e5cc7cf8eff97b357233a507f97fd044b858d07c) exclude everything that's not a number ### 📊 Changes **1 file changed** (+13 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/models/feedbacks.py` (+13 -1) </details> ### 📄 Description ### Description **Problem**: when giving a numeric feedback to a model, a user can skew the statistic by sending a manual request with an arbitrarily positive or negative number. The backend should always validate inputs at the system boundary regardless of how unlikely abuse is. This was flagged by internal QA during a pentest as a medium severity finding. **Solution**: I added some validation to force the numeric feedback between 1 and 10. **Note**: - If the feedback is a negative number, it's registered as 1. - If it's a number greater than 10, it's registered as 10. - If it's anything else, the `details` field is empty ### Added - Added a `details` field to `RatingData`: it reflects what the json object actually is when a rating is applied - Added a validator that cap the rating between 1 and 10 ### Breaking Changes - None: this change has no effect other that adding a `"details": null` to the record if no rating is provided. --- ### Test #### Before 1. Start a new chat 2. Say "hello" 3. Click thumbs up or down and select rating 4. Click send 5. Intercept the request 6. Copy json, change the details 7. Use `curl` to send the changed payload ``` curl -XPOST --header "Content-Type: application/json" --header "Authorization: Bearer xxx" 'http://localhost:8080/api/v1/evaluations/feedback/947a071b-269f-4e91-a245-902ab840fd68' -d @rating.json ``` where the `rating.json` has for example ```json "data": { "rating": 1, "tags": ["General"], "reason": "", "comment": "", "details": { "rating": -1000 }, "model_id": "gemma4:31b-cloud" }, ``` and you can read in the response ```json "data": { "rating": 1, "model_id": "gemma4:31b-cloud", "sibling_model_ids": null, "reason": "", "comment": "", "tags": ["General"], "details": { "rating": -1000 } } ``` and you get <img width="994" height="832" alt="image" src="https://github.com/user-attachments/assets/27cf5c49-d65d-4d78-92d4-7e89f62fbbd0" /> ### After Do the same thing, but this time ```json "data": { "rating": 1, "tags": ["General"], "reason": "", "comment": "", "details": { "rating": 12345 }, "model_id": "gemma4:31b-cloud" } ``` results in ```json "details":{"rating":10} ``` and ```json "data": { "rating": 1, "tags": ["General"], "reason": "", "comment": "", "details": { "rating": -12345 }, "model_id": "gemma4:31b-cloud" } ``` ```json "details":{"rating":1} ``` <img width="491" height="402" alt="Screenshot 2026-04-08 at 12 13 42" src="https://github.com/user-attachments/assets/580b7dcd-2b63-4913-9b00-490ad62106d1" /> <img width="470" height="391" alt="Screenshot 2026-04-08 at 12 12 19" src="https://github.com/user-attachments/assets/29e4cc60-657a-4f4e-b9d2-fa7953b89ba6" /> If I pass a string ```json "data": { "rating": 1, "tags": ["General"], "reason": "", "comment": "", "details": { "rating": "geiwffwegfu" }, "model_id": "gemma4:31b-cloud" } ``` I get ```json "data": { "rating": 1, "tags": ["General"], "reason": "", "comment": "", "details": {}, "model_id": "gemma4:31b-cloud" } ``` and in the UI I have <img width="932" height="780" alt="image" src="https://github.com/user-attachments/assets/43d4d5df-27ea-460e-ab63-adf0e8aaea0c" /> ### Contributor License Agreement <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. Your PR will NOT be reviewed or merged until you check the box below confirming that you have read and agree to the terms of the CLA. --> - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 12:11:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#66079
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?