github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 19:08:59 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #23456] [CLOSED] fix: use os.path.join() for cross-platform audio file paths #66061

New Issue
Closed
opened 2026-05-06 12:10:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-06 12:10:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23456
Author: @theshivam7
Created: 4/6/2026
Status: ❌ Closed

Base: dev ← Head: fix/windows-audio-path

📝 Commits (10+)

📊 Changes

1 file changed (+7 additions, -7 deletions)

View changed files

📝 backend/open_webui/routers/audio.py (+7 -7)

📄 Description

Pull Request Checklist

  • Target branch: dev
  • Description: Provided below
  • Testing: Verified by code inspection — no logic changes, only path construction method changed
  • Code review: Self-reviewed
  • Git Hygiene: Single atomic change

Changelog Entry

Description

Fixes #23444

Audio file path construction in backend/open_webui/routers/audio.py used hardcoded forward-slash f-strings like f'{file_dir}/{filename}', which produce mixed-separator paths on Windows (e.g. C:\...\uploads/xxxx.mp3), causing runtime failures for Windows users.

Fixed

  • Replace 6 hardcoded forward-slash path constructions in audio.py with os.path.join() for cross-platform compatibility
# Before
transcript_file = f'{file_dir}/{id}.json'
file_dir = f'{CACHE_DIR}/audio/transcriptions'
file_path = f'{file_dir}/{filename}'

# After
transcript_file = os.path.join(file_dir, f'{id}.json')
file_dir = os.path.join(CACHE_DIR, 'audio', 'transcriptions')
file_path = os.path.join(file_dir, filename)

No logic changes — os is already imported and os.path.join() is already used elsewhere in this file. The existing path traversal security check is untouched.

Additional Information

Contributor License Agreement

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23456 **Author:** [@theshivam7](https://github.com/theshivam7) **Created:** 4/6/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/windows-audio-path` --- ### 📝 Commits (10+) - [`fe6783c`](https://github.com/open-webui/open-webui/commit/fe6783c16699911c7be17392596d579333fb110c) Merge pull request #19030 from open-webui/dev - [`fc05e0a`](https://github.com/open-webui/open-webui/commit/fc05e0a6c5d39da60b603b4d520f800d6e36f748) Merge pull request #19405 from open-webui/dev - [`e3faec6`](https://github.com/open-webui/open-webui/commit/e3faec62c58e3a83d89aa3df539feacefa125e0c) Merge pull request #19416 from open-webui/dev - [`9899293`](https://github.com/open-webui/open-webui/commit/9899293f050ad50ae12024cbebee7e018acd851e) Merge pull request #19448 from open-webui/dev - [`140605e`](https://github.com/open-webui/open-webui/commit/140605e660b8186a7d5c79fb3be6ffb147a2f498) Merge pull request #19462 from open-webui/dev - [`6f1486f`](https://github.com/open-webui/open-webui/commit/6f1486ffd0cb288d0e21f41845361924e0d742b3) Merge pull request #19466 from open-webui/dev - [`d95f533`](https://github.com/open-webui/open-webui/commit/d95f533214e3fe5beb5e41ec1f349940bc4c7043) Merge pull request #19729 from open-webui/dev - [`a727153`](https://github.com/open-webui/open-webui/commit/a7271532f8a38da46785afcaa7e65f9a45e7d753) 0.6.43 (#20093) - [`6adde20`](https://github.com/open-webui/open-webui/commit/6adde203cd292a9e3af9c64a2ae36b603fed096a) Merge pull request #20394 from open-webui/dev - [`f9b0534`](https://github.com/open-webui/open-webui/commit/f9b0534e0c442631d1cb7205169588b9b6204179) Merge pull request #20522 from open-webui/dev ### 📊 Changes **1 file changed** (+7 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/audio.py` (+7 -7) </details> ### 📄 Description # Pull Request Checklist - [x] **Target branch:** `dev` - [x] **Description:** Provided below - [x] **Testing:** Verified by code inspection — no logic changes, only path construction method changed - [x] **Code review:** Self-reviewed - [x] **Git Hygiene:** Single atomic change --- # Changelog Entry ### Description Fixes #23444 Audio file path construction in `backend/open_webui/routers/audio.py` used hardcoded forward-slash f-strings like `f'{file_dir}/{filename}'`, which produce mixed-separator paths on Windows (e.g. `C:\...\uploads/xxxx.mp3`), causing runtime failures for Windows users. ### Fixed - Replace 6 hardcoded forward-slash path constructions in `audio.py` with `os.path.join()` for cross-platform compatibility ```python # Before transcript_file = f'{file_dir}/{id}.json' file_dir = f'{CACHE_DIR}/audio/transcriptions' file_path = f'{file_dir}/{filename}' # After transcript_file = os.path.join(file_dir, f'{id}.json') file_dir = os.path.join(CACHE_DIR, 'audio', 'transcriptions') file_path = os.path.join(file_dir, filename) ``` No logic changes — `os` is already imported and `os.path.join()` is already used elsewhere in this file. The existing path traversal security check is untouched. --- ### Additional Information - Affects lines 585, 623, 692, 799, 984, 1162, 1164 of `audio.py` - Pure mechanical fix — no new imports, no behavior change on non-Windows platforms - Related issue: #23444 ### Contributor License Agreement - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 12:10:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#66061
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?