[PR #23203] [CLOSED] fix: add missing redirect_uri to Feishu OAuth provider config #65937

New Issue

GiteaMirror · 2026-05-06T12:01:27-05:00

GiteaMirror commented

2026-05-06 12:01:27 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23203
Author: @tuzkiyoung
Created: 3/29/2026
Status: ❌ Closed

Base: dev ← Head: fix/feishu-redirect-uri

📝 Commits (1)

62c6853 fix: add missing redirect_uri to Feishu OAuth provider config. The OAUTH_PROVIDERS['feishu'] dict was missing the 'redirect_uri' key,causing handle_login() to fall back to request.url_for() which generates. http:// URLs behind a reverse proxy. All other providers (Google, Microsoft, GitHub, OIDC) already include this key.

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 backend/open_webui/config.py (+1 -0)

📄 Description

Fixes #23128
Supersedes #23129

Target branch: dev
Description: See below
Changelog: See below
Documentation: No doc changes needed — FEISHU_CLIENT_REDIRECT_URI env var is already documented
Dependencies: No new dependencies
Testing: Manually tested Feishu OAuth login behind ALB Ingress (Kubernetes), confirmed redirect URI is now https://
Agentic AI Code: This is a one-line fix identified through manual debugging, reviewed and tested by a human
Code review: Self-reviewed
Design & Architecture: No new settings, just fixing an omission to match existing pattern
Git Hygiene: Single atomic commit, rebased on dev
Title Prefix: fix:

Changelog Entry

Description

Fix Feishu OAuth login failing with HTTPS behind reverse proxy due to missing redirect_uri in OAUTH_PROVIDERS['feishu'] dict

Fixed

Add missing redirect_uri key to OAUTH_PROVIDERS['feishu'] in config.py. FEISHU_REDIRECT_URI was already defined and passed to oauth.register() but was not included in the OAUTH_PROVIDERS dict that handle_login() reads from. This caused handle_login() to fall back to request.url_for()
which generates http:// redirect URIs behind a reverse proxy. All other providers (Google, Microsoft, GitHub, OIDC) already include this key. This bug may not surface when the proxy correctly forwards X-Forwarded-Proto: https (e.g. single-layer Docker + ALB), but breaks in multi-layer proxy setups
(e.g. Kubernetes with Ingress).

Additional Information

Related env var: FEISHU_CLIENT_REDIRECT_URI
Affected file: backend/open_webui/config.py
The fix is one line, consistent with how all other OAuth providers are configured

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23203 **Author:** [@tuzkiyoung](https://github.com/tuzkiyoung) **Created:** 3/29/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/feishu-redirect-uri` --- ### 📝 Commits (1) - [`62c6853`](https://github.com/open-webui/open-webui/commit/62c68534454b120aea0ae95a76ba9c9434579ed6) fix: add missing redirect_uri to Feishu OAuth provider config. The OAUTH_PROVIDERS['feishu'] dict was missing the 'redirect_uri' key,causing handle_login() to fall back to request.url_for() which generates. http:// URLs behind a reverse proxy. All other providers (Google, Microsoft, GitHub, OIDC) already include this key. ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/config.py` (+1 -0) </details> ### 📄 Description Fixes #23128 Supersedes #23129 - [x] **Target branch:** `dev` - [x] **Description:** See below - [x] **Changelog:** See below - [ ] **Documentation:** No doc changes needed — `FEISHU_CLIENT_REDIRECT_URI` env var is already documented - [ ] **Dependencies:** No new dependencies - [x] **Testing:** Manually tested Feishu OAuth login behind ALB Ingress (Kubernetes), confirmed redirect URI is now `https://` - [x] **Agentic AI Code:** This is a one-line fix identified through manual debugging, reviewed and tested by a human - [x] **Code review:** Self-reviewed - [x] **Design & Architecture:** No new settings, just fixing an omission to match existing pattern - [x] **Git Hygiene:** Single atomic commit, rebased on `dev` - [x] **Title Prefix:** `fix:` # Changelog Entry ### Description - Fix Feishu OAuth login failing with HTTPS behind reverse proxy due to missing `redirect_uri` in `OAUTH_PROVIDERS['feishu']` dict ### Fixed - Add missing `redirect_uri` key to `OAUTH_PROVIDERS['feishu']` in `config.py`. `FEISHU_REDIRECT_URI` was already defined and passed to `oauth.register()` but was not included in the `OAUTH_PROVIDERS` dict that `handle_login()` reads from. This caused `handle_login()` to fall back to `request.url_for()` which generates `http://` redirect URIs behind a reverse proxy. All other providers (Google, Microsoft, GitHub, OIDC) already include this key. This bug may not surface when the proxy correctly forwards `X-Forwarded-Proto: https` (e.g. single-layer Docker + ALB), but breaks in multi-layer proxy setups (e.g. Kubernetes with Ingress). --- ### Additional Information - Related env var: `FEISHU_CLIENT_REDIRECT_URI` - Affected file: `backend/open_webui/config.py` - The fix is one line, consistent with how all other OAuth providers are configured ### Contributor License Agreement - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-06 12:01:27 -05:00

GiteaMirror closed this issue

2026-05-06 12:01:29 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#65937