[PR #23093] [CLOSED] fix: refresh forwarded system oauth id token for OpenAI proxy #65878

New Issue

GiteaMirror · 2026-05-06T11:54:34-05:00

GiteaMirror commented

2026-05-06 11:54:34 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23093
Author: @raashish1601
Created: 3/26/2026
Status: ❌ Closed

Base: dev ← Head: fix/refresh-system-oauth-id-token

📝 Commits (1)

3ae0c73 fix: refresh forwarded system oauth id token

📊 Changes

2 files changed (+77 additions, -2 deletions)

View changed files

📝 backend/open_webui/routers/openai.py (+8 -2)
➕ backend/open_webui/test/apps/webui/routers/test_openai.py (+69 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. PRs targeting main will be immediately closed.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Add docs in Open WebUI Docs Repository. Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps.
Dependencies: Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash.
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to make screenshots of the feature/fix and include them in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Design & Architecture: Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes.
Git Hygiene: Keep PRs atomic (one logical change). Clean up commits and rebase on dev to ensure no unrelated commits (e.g. from main) are included. Push updates to the existing PR branch instead of closing and reopening.
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Refresh the forwarded oauth_id_token cookie during system_oauth OpenAI proxy requests so custom Responses backends receive the current token instead of a stale browser cookie.

Added

Regression tests for get_headers_and_cookies covering refreshed and missing id_token cases.

Changed

get_headers_and_cookies now clones forwarded cookies for system_oauth requests and replaces oauth_id_token with the latest token from the OAuth session when available.

Deprecated

None.

Removed

None.

Fixed

Closes #23074.
Custom OpenAI-compatible backends that rely on the forwarded oauth_id_token cookie now receive the refreshed token during /responses and other OpenAI proxy requests.
Existing cookie values are preserved when the refreshed session does not provide a new id_token.

Security

Keeps the forwarded OAuth identity cookie aligned with the active OAuth session after refresh instead of continuing to forward an expired value.

Breaking Changes

BREAKING CHANGE: None.

Additional Information

No new dependencies were added to the repository.
No docs repo change was needed because this corrects internal forwarding for existing system_oauth behavior without introducing new settings or APIs.
Manual validation:
- python -m uv run --group dev pytest backend/open_webui/test/apps/webui/routers/test_openai.py
- python -m uv run --group dev ruff check backend/open_webui/test/apps/webui/routers/test_openai.py
Screenshots are not applicable for this backend-only token forwarding fix.

Screenshots or Videos

N/A (backend-only fix).

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23093 **Author:** [@raashish1601](https://github.com/raashish1601) **Created:** 3/26/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/refresh-system-oauth-id-token` --- ### 📝 Commits (1) - [`3ae0c73`](https://github.com/open-webui/open-webui/commit/3ae0c734c8f92557c512aa53bf8301baa1be2abf) fix: refresh forwarded system oauth id token ### 📊 Changes **2 files changed** (+77 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/openai.py` (+8 -2) ➕ `backend/open_webui/test/apps/webui/routers/test_openai.py` (+69 -0) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **PRs targeting `main` will be immediately closed.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Add docs in [Open WebUI Docs Repository](https://github.com/open-webui/docs). Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps. - [x] **Dependencies:** Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash. - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to **make screenshots of the feature/fix and include them in the PR description**. - [ ] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Design & Architecture:** Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes. - [x] **Git Hygiene:** Keep PRs atomic (one logical change). Clean up commits and rebase on `dev` to ensure no unrelated commits (e.g. from `main`) are included. Push updates to the existing PR branch instead of closing and reopening. - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Refresh the forwarded `oauth_id_token` cookie during `system_oauth` OpenAI proxy requests so custom Responses backends receive the current token instead of a stale browser cookie. ### Added - Regression tests for `get_headers_and_cookies` covering refreshed and missing `id_token` cases. ### Changed - `get_headers_and_cookies` now clones forwarded cookies for `system_oauth` requests and replaces `oauth_id_token` with the latest token from the OAuth session when available. ### Deprecated - None. ### Removed - None. ### Fixed - Closes #23074. - Custom OpenAI-compatible backends that rely on the forwarded `oauth_id_token` cookie now receive the refreshed token during `/responses` and other OpenAI proxy requests. - Existing cookie values are preserved when the refreshed session does not provide a new `id_token`. ### Security - Keeps the forwarded OAuth identity cookie aligned with the active OAuth session after refresh instead of continuing to forward an expired value. ### Breaking Changes - **BREAKING CHANGE**: None. --- ### Additional Information - No new dependencies were added to the repository. - No docs repo change was needed because this corrects internal forwarding for existing `system_oauth` behavior without introducing new settings or APIs. - Manual validation: - `python -m uv run --group dev pytest backend/open_webui/test/apps/webui/routers/test_openai.py` - `python -m uv run --group dev ruff check backend/open_webui/test/apps/webui/routers/test_openai.py` - Screenshots are not applicable for this backend-only token forwarding fix. ### Screenshots or Videos - N/A (backend-only fix). ### Contributor License Agreement  - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-06 11:54:34 -05:00

GiteaMirror closed this issue

2026-05-06 11:54:37 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#65878