[PR #22834] [CLOSED] fix: prevent event bubbling on memory delete/edit buttons #65737

New Issue

GiteaMirror · 2026-05-06T11:39:42-05:00

GiteaMirror commented

2026-05-06 11:39:42 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/22834
Author: @xr843
Created: 3/19/2026
Status: ❌ Closed

Base: dev ← Head: fix/22783-memory-delete-event-bubbling

📝 Commits (1)

f99531a fix: prevent event bubbling on memory delete/edit buttons (#22783)

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/lib/components/chat/Settings/Personalization/ManageModal.svelte (+2 -2)

📄 Description

Pull Request Checklist

Target branch: Targets dev branch.
Description: Provided below.
Changelog: Included below.
Testing: Manually verified that clicking Delete no longer opens the Edit modal.
Code review: Self-reviewed.

Changelog Entry

Description

Fixes event bubbling issue where clicking Delete or Edit buttons in the Memory management modal triggers the parent div's click handler, causing the Edit modal to open unexpectedly (#22783).

Fixed

Added |stopPropagation modifier to Edit and Delete button on:click handlers in ManageModal.svelte to prevent click events from propagating to the parent element.

Additional Information

Closes [PR #11727] [CLOSED] feat: Save prompts from chat response (#22783)
The fix is minimal: two |stopPropagation modifiers on existing click handlers.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/22834 **Author:** [@xr843](https://github.com/xr843) **Created:** 3/19/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/22783-memory-delete-event-bubbling` --- ### 📝 Commits (1) - [`f99531a`](https://github.com/open-webui/open-webui/commit/f99531a200b2b621311005f0991b05147117a2b3) fix: prevent event bubbling on memory delete/edit buttons (#22783) ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Settings/Personalization/ManageModal.svelte` (+2 -2) </details> ### 📄 Description # Pull Request Checklist - [x] **Target branch:** Targets `dev` branch. - [x] **Description:** Provided below. - [x] **Changelog:** Included below. - [x] **Testing:** Manually verified that clicking Delete no longer opens the Edit modal. - [x] **Code review:** Self-reviewed. # Changelog Entry ### Description - Fixes event bubbling issue where clicking Delete or Edit buttons in the Memory management modal triggers the parent div's click handler, causing the Edit modal to open unexpectedly (#22783). ### Fixed - Added `|stopPropagation` modifier to Edit and Delete button `on:click` handlers in `ManageModal.svelte` to prevent click events from propagating to the parent element. --- ### Additional Information - Closes #22783 - The fix is minimal: two `|stopPropagation` modifiers on existing click handlers. ### Contributor License Agreement - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-06 11:39:42 -05:00

GiteaMirror closed this issue

2026-05-06 11:39:45 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#65737