github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-07-16 06:03:26 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #22700] [CLOSED] fix: add missing has_public_read_access_grant import in notes.py #65675

New Issue
Closed
opened 2026-05-06 11:34:42 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-06 11:34:42 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/22700
Author: @mvanhorn
Created: 3/15/2026
Status: ❌ Closed

Base: main ← Head: osc/22680-notes-missing-import

📝 Commits (1)

  • 4b0a750 fix: add missing has_public_read_access_grant import in notes.py

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 backend/open_webui/routers/notes.py (+1 -1)

📄 Description

Summary

Adds the missing has_public_read_access_grant import to notes.py. The function is called at line 239 but was never imported, causing a NameError at runtime.

Changes

Added has_public_read_access_grant to the existing import from open_webui.models.access_grants on line 31. This matches the import pattern already used in channels.py:39.

Testing

  • Verified the function exists in models/access_grants.py:193
  • Verified channels.py uses the same import pattern successfully
  • The fix is a single import addition with no behavioral change beyond fixing the NameError

Fixes #22680

This contribution was developed with AI assistance (Claude Code).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/22700 **Author:** [@mvanhorn](https://github.com/mvanhorn) **Created:** 3/15/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `osc/22680-notes-missing-import` --- ### 📝 Commits (1) - [`4b0a750`](https://github.com/open-webui/open-webui/commit/4b0a750ee9f5ff5300fe73a7ed20f48545735126) fix: add missing has_public_read_access_grant import in notes.py ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/notes.py` (+1 -1) </details> ### 📄 Description ## Summary Adds the missing `has_public_read_access_grant` import to `notes.py`. The function is called at line 239 but was never imported, causing a `NameError` at runtime. ## Changes Added `has_public_read_access_grant` to the existing import from `open_webui.models.access_grants` on line 31. This matches the import pattern already used in `channels.py:39`. ## Testing - Verified the function exists in `models/access_grants.py:193` - Verified `channels.py` uses the same import pattern successfully - The fix is a single import addition with no behavioral change beyond fixing the NameError Fixes #22680 This contribution was developed with AI assistance (Claude Code). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 11:34:42 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#65675
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?