github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 10:58:17 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #22667] [CLOSED] fix: register memory tools when model declares capabilities.memory #65662

New Issue
Closed
opened 2026-05-06 11:33:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-06 11:33:54 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/22667
Author: @Thump604
Created: 3/14/2026
Status: ❌ Closed

Base: dev ← Head: fix/memory-tools-capability-fallback

📝 Commits (10+)

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 backend/open_webui/utils/tools.py (+1 -1)

📄 Description

Pull Request Checklist

  • Target branch: dev
  • Description: See below
  • Testing: Manually tested — screenshots included
  • Agentic AI Code: Human-reviewed and manually tested
  • Code review: Self-reviewed
  • Title Prefix: fix:

Changelog Entry

Description

When a model declares capabilities.memory: true in its meta config, memory tools (add_memory, search_memories, etc.) should be registered for execution. Without this fix, models with native function calling and memory capability enter a 30-iteration tool retry loop because add_memory appears in the tool schema but isn't in the execution dict.

Root Cause

get_builtin_tools() in utils/tools.py only checked features.get("memory") (per-chat toggle sent by frontend). This could be False even when:

  • The admin memory setting is enabled
  • The model explicitly declares capabilities.memory: true
  • The frontend sends features.memory: true for some chats but not others

This is inconsistent with how other capabilities like web_search and image_generation are handled elsewhere in the codebase.

Changed

  • backend/open_webui/utils/tools.py: get_builtin_tools() now also checks get_model_capability("memory", False) as a fallback when features.get("memory") is not set

Steps to Reproduce (Before Fix)

  1. Configure a model with capabilities.memory: true and function_calling: native
  2. Ensure admin memory setting is ON
  3. Send "Remember my favorite color is blue"
  4. Model calls add_memory but tool is not in execution dict → empty result → 30-iteration retry loop

Steps to Verify (After Fix)

  1. Same config as above
  2. Send "Remember my favorite color is blue" → single add_memory call → DB row created
  3. New chat → "What is my favorite color?" → search_memories → correct recall

Fixes #22666

Contributor License Agreement

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/22667 **Author:** [@Thump604](https://github.com/Thump604) **Created:** 3/14/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/memory-tools-capability-fallback` --- ### 📝 Commits (10+) - [`fe6783c`](https://github.com/open-webui/open-webui/commit/fe6783c16699911c7be17392596d579333fb110c) Merge pull request #19030 from open-webui/dev - [`fc05e0a`](https://github.com/open-webui/open-webui/commit/fc05e0a6c5d39da60b603b4d520f800d6e36f748) Merge pull request #19405 from open-webui/dev - [`e3faec6`](https://github.com/open-webui/open-webui/commit/e3faec62c58e3a83d89aa3df539feacefa125e0c) Merge pull request #19416 from open-webui/dev - [`9899293`](https://github.com/open-webui/open-webui/commit/9899293f050ad50ae12024cbebee7e018acd851e) Merge pull request #19448 from open-webui/dev - [`140605e`](https://github.com/open-webui/open-webui/commit/140605e660b8186a7d5c79fb3be6ffb147a2f498) Merge pull request #19462 from open-webui/dev - [`6f1486f`](https://github.com/open-webui/open-webui/commit/6f1486ffd0cb288d0e21f41845361924e0d742b3) Merge pull request #19466 from open-webui/dev - [`d95f533`](https://github.com/open-webui/open-webui/commit/d95f533214e3fe5beb5e41ec1f349940bc4c7043) Merge pull request #19729 from open-webui/dev - [`a727153`](https://github.com/open-webui/open-webui/commit/a7271532f8a38da46785afcaa7e65f9a45e7d753) 0.6.43 (#20093) - [`6adde20`](https://github.com/open-webui/open-webui/commit/6adde203cd292a9e3af9c64a2ae36b603fed096a) Merge pull request #20394 from open-webui/dev - [`f9b0534`](https://github.com/open-webui/open-webui/commit/f9b0534e0c442631d1cb7205169588b9b6204179) Merge pull request #20522 from open-webui/dev ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/tools.py` (+1 -1) </details> ### 📄 Description <!-- ⚠️ CRITICAL CHECKS FOR CONTRIBUTORS (READ, DON'T DELETE) ⚠️ 1. Target the `dev` branch. PRs targeting `main` will be automatically closed. 2. Do NOT delete the CLA section at the bottom. It is required for the bot to accept your PR. --> # Pull Request Checklist - [x] **Target branch:** `dev` - [x] **Description:** See below - [x] **Testing:** Manually tested — screenshots included - [x] **Agentic AI Code:** Human-reviewed and manually tested - [x] **Code review:** Self-reviewed - [x] **Title Prefix:** `fix:` # Changelog Entry ### Description When a model declares `capabilities.memory: true` in its meta config, memory tools (`add_memory`, `search_memories`, etc.) should be registered for execution. Without this fix, models with native function calling and memory capability enter a 30-iteration tool retry loop because `add_memory` appears in the tool schema but isn't in the execution dict. ### Root Cause `get_builtin_tools()` in `utils/tools.py` only checked `features.get("memory")` (per-chat toggle sent by frontend). This could be `False` even when: - The admin memory setting is enabled - The model explicitly declares `capabilities.memory: true` - The frontend sends `features.memory: true` for some chats but not others This is inconsistent with how other capabilities like `web_search` and `image_generation` are handled elsewhere in the codebase. ### Changed - `backend/open_webui/utils/tools.py`: `get_builtin_tools()` now also checks `get_model_capability("memory", False)` as a fallback when `features.get("memory")` is not set ### Steps to Reproduce (Before Fix) 1. Configure a model with `capabilities.memory: true` and `function_calling: native` 2. Ensure admin memory setting is ON 3. Send "Remember my favorite color is blue" 4. Model calls `add_memory` but tool is not in execution dict → empty result → 30-iteration retry loop ### Steps to Verify (After Fix) 1. Same config as above 2. Send "Remember my favorite color is blue" → single `add_memory` call → DB row created 3. New chat → "What is my favorite color?" → `search_memories` → correct recall Fixes #22666 ### Contributor License Agreement <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. Your PR will NOT be reviewed or merged until you check the box below confirming that you have read and agree to the terms of the CLA. --> - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 11:33:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#65662
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?