[PR #22486] [MERGED] fix: add profile image fallback handlers for model and user avatars in remaining areas #65580

New Issue

Closed

opened 2026-05-06 11:27:17 -05:00 by GiteaMirror · 0 comments

GiteaMirror commented 2026-05-06 11:27:17 -05:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/22486
Author: @silentoplayz
Created: 3/9/2026
Status: ✅ Merged
Merged: 3/16/2026
Merged by: @tjbck

Base: dev ← Head: fix/model-icon-fallbacks

---

📝 Commits (3)

• 451d411 fix(ui): add profile image fallback handlers for models and users
• e2b0f14 Update UserList.svelte
• dabf285 fix(ui): add profile image fallback handlers for models on New Chat page

📊 Changes

8 files changed (+30 additions, -0 deletions)

View changed files

📝 src/lib/components/admin/Users/UserList.svelte (+3 -0)
📝 src/lib/components/channel/MessageInput/MentionList.svelte (+6 -0)
📝 src/lib/components/channel/Messages/Message.svelte (+6 -0)
📝 src/lib/components/chat/ChatPlaceholder.svelte (+3 -0)
📝 src/lib/components/chat/MessageInput/Commands/Models.svelte (+3 -0)
📝 src/lib/components/chat/ModelSelector/ModelItem.svelte (+3 -0)
📝 src/lib/components/chat/Placeholder.svelte (+3 -0)
📝 src/lib/components/layout/Sidebar/PinnedModelItem.svelte (+3 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

• Target branch: Verify that the pull request targets the dev branch. PRs targeting main will be immediately closed.
• Description: Provide a concise description of the changes made in this pull request down below.
• Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
• Documentation: Add docs in Open WebUI Docs Repository. Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps.
• Dependencies: Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash.
• Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to make screenshots of the feature/fix and include them in the PR description.
• Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
• Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
• Design & Architecture: Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes.
• Git Hygiene: Keep PRs atomic (one logical change). Clean up commits and rebase on dev to ensure no unrelated commits (e.g. from main) are included. Push updates to the existing PR branch instead of closing and reopening.
• Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
  • fix: Bug fix or error correction

Changelog Entry

Description

• Added on:error fallback handlers to model and user profile images in several UI components to prevent broken icons when images fail to load.
• Components updated: MentionList, Message, Commands/Models (command list), ModelSelector/ModelItem, and PinnedModelItem in Sidebar.
• Implemented consistent fallback to /favicon.png for all model/user profile image tags.

Fixed

• UI: Fixed broken image icons for models and users by adding client-side error handling that triggers a fallback to the default favicon.

---

Additional Information

• Changes were implemented across:

  • src/lib/components/channel/MessageInput/MentionList.svelte
  • src/lib/components/channel/Messages/Message.svelte
  • src/lib/components/chat/MessageInput/Commands/Models.svelte
  • src/lib/components/chat/ModelSelector/ModelItem.svelte
  • src/lib/components/layout/Sidebar/PinnedModelItem.svelte
  • src/lib/components/admin/Users/UserList.svelte
  • src/lib/components/chat/ChatPlaceholder.svelte
  • src/lib/components/chat/Placeholder.svelte

• This fix follows the pattern established in PRs #21730, #21897, and #22485.

Screenshots or Videos

Before - src/lib/components/channel/MessageInput/MentionList.svelte

After - src/lib/components/channel/MessageInput/MentionList.svelte

Before - src/lib/components/channel/Messages/Message.svelte

After - src/lib/components/channel/Messages/Message.svelte

Before - src/lib/components/chat/MessageInput/Commands/Models.svelte

After - src/lib/components/chat/MessageInput/Commands/Models.svelte

Before - src/lib/components/chat/ModelSelector/ModelItem.svelte

After - src/lib/components/chat/ModelSelector/ModelItem.svelte

Before - src/lib/components/layout/Sidebar/PinnedModelItem.svelte

After - src/lib/components/layout/Sidebar/PinnedModelItem.svelte

Before - src/lib/components/admin/Users/UserList.svelte

After - src/lib/components/admin/Users/UserList.svelte

Before - src/lib/components/chat/ChatPlaceholder.svelte

After - src/lib/components/chat/ChatPlaceholder.svelte

It's worth mentioning that the 'After' screenshots might not always reflect the fix, since proper image loading can be hit-or-miss. User and model avatars can fail to load properly, and in that case, should default to the favicon image, but this can be very tricky to capture accurately within a screenshot.

Contributor License Agreement

• By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/22486 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 3/9/2026 **Status:** ✅ Merged **Merged:** 3/16/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/model-icon-fallbacks` --- ### 📝 Commits (3) - [`451d411`](https://github.com/open-webui/open-webui/commit/451d411c27a8560b7b26de3974eacf8e9ee9a9eb) fix(ui): add profile image fallback handlers for models and users - [`e2b0f14`](https://github.com/open-webui/open-webui/commit/e2b0f14a72f4f17798658d01019fc3f53ff2f108) Update UserList.svelte - [`dabf285`](https://github.com/open-webui/open-webui/commit/dabf28563b7102e3d59b411acce3d4c17f227d46) fix(ui): add profile image fallback handlers for models on New Chat page ### 📊 Changes **8 files changed** (+30 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/admin/Users/UserList.svelte` (+3 -0) 📝 `src/lib/components/channel/MessageInput/MentionList.svelte` (+6 -0) 📝 `src/lib/components/channel/Messages/Message.svelte` (+6 -0) 📝 `src/lib/components/chat/ChatPlaceholder.svelte` (+3 -0) 📝 `src/lib/components/chat/MessageInput/Commands/Models.svelte` (+3 -0) 📝 `src/lib/components/chat/ModelSelector/ModelItem.svelte` (+3 -0) 📝 `src/lib/components/chat/Placeholder.svelte` (+3 -0) 📝 `src/lib/components/layout/Sidebar/PinnedModelItem.svelte` (+3 -0) </details> ### 📄 Description <!-- ⚠️ CRITICAL CHECKS FOR CONTRIBUTORS (READ, DON'T DELETE) ⚠️ 1. Target the `dev` branch. PRs targeting `main` will be automatically closed. 2. Do NOT delete the CLA section at the bottom. It is required for the bot to accept your PR. --> # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **PRs targeting `main` will be immediately closed.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Add docs in [Open WebUI Docs Repository](https://github.com/open-webui/docs). Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps. - [x] **Dependencies:** Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash. - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to **make screenshots of the feature/fix and include them in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Design & Architecture:** Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes. - [x] **Git Hygiene:** Keep PRs atomic (one logical change). Clean up commits and rebase on `dev` to ensure no unrelated commits (e.g. from `main`) are included. Push updates to the existing PR branch instead of closing and reopening. - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **fix**: Bug fix or error correction # Changelog Entry ### Description - Added `on:error` fallback handlers to model and user profile images in several UI components to prevent broken icons when images fail to load. - Components updated: `MentionList`, `Message`, `Commands/Models` (command list), `ModelSelector/ModelItem`, and `PinnedModelItem` in Sidebar. - Implemented consistent fallback to `/favicon.png` for all model/user profile image tags. ### Fixed - **UI**: Fixed broken image icons for models and users by adding client-side error handling that triggers a fallback to the default favicon. --- ### Additional Information - Changes were implemented across: - `src/lib/components/channel/MessageInput/MentionList.svelte` - `src/lib/components/channel/Messages/Message.svelte` - `src/lib/components/chat/MessageInput/Commands/Models.svelte` - `src/lib/components/chat/ModelSelector/ModelItem.svelte` - `src/lib/components/layout/Sidebar/PinnedModelItem.svelte` - `src/lib/components/admin/Users/UserList.svelte` - `src/lib/components/chat/ChatPlaceholder.svelte` - `src/lib/components/chat/Placeholder.svelte` - This fix follows the pattern established in PRs #21730, #21897, and #22485. ### Screenshots or Videos ### Before - `src/lib/components/channel/MessageInput/MentionList.svelte` <img width="335" height="316" alt="image" src="https://github.com/user-attachments/assets/7e7d6522-7598-4690-8999-9a7ad5c17d28" /> ### After - `src/lib/components/channel/MessageInput/MentionList.svelte` <img width="335" height="316" alt="image" src="https://github.com/user-attachments/assets/3aab6ae7-4885-40e3-815e-0fca4bfffc89" /> ### Before - `src/lib/components/channel/Messages/Message.svelte` <img width="335" height="316" alt="image" src="https://github.com/user-attachments/assets/7e337912-e171-4217-860c-96124c1a84a3" /> ### After - `src/lib/components/channel/Messages/Message.svelte` <img width="335" height="316" alt="image" src="https://github.com/user-attachments/assets/fca9ae5b-ebb0-48d7-9668-000e060bb66d" /> ### Before - `src/lib/components/chat/MessageInput/Commands/Models.svelte` <img width="1175" height="506" alt="image" src="https://github.com/user-attachments/assets/8d7fac24-f394-452f-95d1-1b77bbdbbefd" /> ### After - `src/lib/components/chat/MessageInput/Commands/Models.svelte` <img width="1175" height="506" alt="image" src="https://github.com/user-attachments/assets/0041db98-87ae-44ff-9c17-b080e322c69f" /> ### Before - `src/lib/components/chat/ModelSelector/ModelItem.svelte` <img width="546" height="391" alt="image" src="https://github.com/user-attachments/assets/3ed77124-3079-4164-a7f9-08165ebb6ab8" /> ### After - `src/lib/components/chat/ModelSelector/ModelItem.svelte` <img width="546" height="391" alt="image" src="https://github.com/user-attachments/assets/b3ae4ecd-379f-4f3e-bdd7-337a1b69ce97" /> ### Before - `src/lib/components/layout/Sidebar/PinnedModelItem.svelte` <img width="216" height="118" alt="image" src="https://github.com/user-attachments/assets/01fbfb87-f877-44a8-a8fc-ebb1585a9e56" /> ### After - `src/lib/components/layout/Sidebar/PinnedModelItem.svelte` <img width="216" height="118" alt="image" src="https://github.com/user-attachments/assets/4596fa73-34ff-4576-82ab-1e599bedc2f3" /> ### Before - `src/lib/components/admin/Users/UserList.svelte` <img width="271" height="247" alt="image" src="https://github.com/user-attachments/assets/44c564e6-4981-407a-aed0-41ca15b9dfe0" /> ### After - `src/lib/components/admin/Users/UserList.svelte` <img width="271" height="247" alt="image" src="https://github.com/user-attachments/assets/52b448c1-7db1-4f96-a7ac-1701dcf177d7" /> ### Before - `src/lib/components/chat/ChatPlaceholder.svelte` <img width="1459" height="857" alt="image" src="https://github.com/user-attachments/assets/315f39e3-b425-4e0b-bd35-090cbff5431a" /> ### After - `src/lib/components/chat/ChatPlaceholder.svelte` <img width="1459" height="857" alt="image" src="https://github.com/user-attachments/assets/a8599cf7-2f0d-4ca6-87d9-4565afd7fa10" /> ## It's worth mentioning that the 'After' screenshots might not always reflect the fix, since proper image loading can be hit-or-miss. User and model avatars can fail to load properly, and in that case, should default to the favicon image, but this can be very tricky to capture accurately within a screenshot. ### Contributor License Agreement <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. Your PR will NOT be reviewed or merged until you check the box below confirming that you have read and agree to the terms of the CLA. --> - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2026-05-06 11:27:17 -05:00

GiteaMirror closed this issue 2026-05-06 11:27:24 -05:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

dev

v0.9.2

v0.9.1

v0.9.0

v0.8.12

v0.8.11

v0.8.10

v0.8.9

v0.8.8

v0.8.7

v0.8.6

v0.8.5

v0.8.4

v0.8.3

v0.8.2

v0.8.1

v0.8.0

v0.7.2

v0.7.1

v0.7.0

v0.6.43

v0.6.42

v0.6.41

v0.6.40

v0.6.39

v0.6.38

v0.6.37

v0.6.36

v0.6.35

v0.6.34

v0.6.33

v0.6.32

v0.6.31

v0.6.30

v0.6.29

v0.6.28

v0.6.27

v0.6.26

v0.6.25

v0.6.24

v0.6.23

v0.6.22

v0.6.21

v0.6.20

v0.6.19

v0.6.18

v0.6.17

v0.6.16

v0.6.15

v0.6.14

v0.6.13

v0.6.12

v0.6.11

v0.6.10

v0.6.9

v0.6.8

v0.6.7

v0.6.6

v0.6.5

v0.6.4

v0.6.3

v0.6.2

v0.6.1

v0.6.0

v0.5.20

v0.5.19

v0.5.18

v0.5.17

v0.5.16

v0.5.15

v0.5.14

v0.5.13

v0.5.12

v0.5.11

v0.5.10

v0.5.9

v0.5.8

v0.5.7

v0.5.6

v0.5.5

v0.5.4

v0.5.3

v0.5.2

v0.5.1

v0.5.0

v0.4.8

v0.4.7

v0.4.6

v0.4.5

v0.4.4

v0.4.3

v0.4.2

v0.4.1

v0.4.0

v0.3.35

v0.3.34

v0.3.33

v0.3.32

v0.3.31

v0.3.30

v0.3.29

v0.3.28

v0.3.27

v0.3.26

v0.3.25

v0.3.24

v0.3.23

v0.3.22

v0.3.21

v0.3.20

v0.3.19

v0.3.18

v0.3.17

v0.3.16

v0.3.15

v0.3.14

v0.3.13

v0.3.12

v0.3.11

v0.3.10

v0.3.9

v0.3.8

v0.3.7

v0.3.6

v0.3.5

v0.3.4

v0.3.3

v0.3.2

v0.3.1

v0.3.0

v0.2.5

v0.2.4

v0.2.3

v0.2.2

v0.2.1

v0.2.0

v0.1.125

v0.1.124

v0.1.123

v0.1.122

v0.1.121

v0.1.120

v0.1.119

v0.1.118

v0.1.117

v0.1.116

v0.1.115

v0.1.114

v0.1.113

v0.1.112

v0.1.111

v0.1.110

v0.1.109

v0.1.108

v0.1.107

v0.1.106

v0.1.105

v0.1.104

v0.1.103

v0.1.102

Labels

Clear labels

bug

confirmed

confirmed issue

core

documentation

enhancement

good first issue

help wanted

non-core

pull-request

Mirrored from GitHub Pull Request

python

question

testing wanted

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

GiteaMirror ninjasurge

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#65580