[PR #22279] [CLOSED] perf: memoize sourceIds computation in ContentRenderer #65440

Closed
opened 2026-05-06 11:16:05 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/22279
Author: @Classic298
Created: 3/5/2026
Status: Closed

Base: devHead: perf/memoize-source-ids


📝 Commits (1)

  • 88af78c perf: memoize sourceIds computation in ContentRenderer

📊 Changes

1 file changed (+25 additions, -30 deletions)

View changed files

📝 src/lib/components/chat/Messages/ContentRenderer.svelte (+25 -30)

📄 Description

Move the sourceIds computation from an inline prop expression (recomputed on every render) to a Svelte reactive variable that only recomputes when sources or model actually change.

Also simplified the reduce+spread+filter deduplication pattern to a straightforward loop with Set-based deduplication.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/22279 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 3/5/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `perf/memoize-source-ids` --- ### 📝 Commits (1) - [`88af78c`](https://github.com/open-webui/open-webui/commit/88af78cab8366ddb4e2e3dcda76df013283d8f40) perf: memoize sourceIds computation in ContentRenderer ### 📊 Changes **1 file changed** (+25 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Messages/ContentRenderer.svelte` (+25 -30) </details> ### 📄 Description Move the sourceIds computation from an inline prop expression (recomputed on every render) to a Svelte reactive variable that only recomputes when sources or model actually change. Also simplified the reduce+spread+filter deduplication pattern to a straightforward loop with Set-based deduplication. ### Contributor License Agreement <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. --> By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 11:16:05 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#65440