[PR #22105] [CLOSED] perf: cache marked.lexer() calls for alert and details block content #65344

Closed
opened 2026-05-06 11:07:54 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/22105
Author: @Classic298
Created: 3/1/2026
Status: Closed

Base: devHead: perf/cache-sublexer-calls


📝 Commits (1)

  • c00d3a4 perf: cache marked.lexer() calls for alert and details block content

📊 Changes

2 files changed (+17 additions, -3 deletions)

View changed files

📝 src/lib/components/chat/Messages/Markdown/AlertRenderer.svelte (+15 -1)
📝 src/lib/components/chat/Messages/Markdown/MarkdownTokens.svelte (+2 -2)

📄 Description

alertComponent() and the details block renderer both call marked.lexer() inline during rendering. Since these run inside {#each tokens} loops, they re-lex on every render cycle even when the text content hasn't changed. Add a simple text-keyed cache (capped at 100 entries) that returns cached tokens for unchanged text, avoiding redundant parsing during streaming.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/22105 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 3/1/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `perf/cache-sublexer-calls` --- ### 📝 Commits (1) - [`c00d3a4`](https://github.com/open-webui/open-webui/commit/c00d3a4d94a20a62ea3409aaef71f9ecb86d508d) perf: cache marked.lexer() calls for alert and details block content ### 📊 Changes **2 files changed** (+17 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Messages/Markdown/AlertRenderer.svelte` (+15 -1) 📝 `src/lib/components/chat/Messages/Markdown/MarkdownTokens.svelte` (+2 -2) </details> ### 📄 Description alertComponent() and the details block renderer both call marked.lexer() inline during rendering. Since these run inside {#each tokens} loops, they re-lex on every render cycle even when the text content hasn't changed. Add a simple text-keyed cache (capped at 100 entries) that returns cached tokens for unchanged text, avoiding redundant parsing during streaming. ### Contributor License Agreement <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. --> By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 11:07:54 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#65344