[PR #20931] [MERGED] fix: remove invalid expunge call on Pydantic FileModel #64695

New Issue

GiteaMirror · 2026-05-06T10:20:37-05:00

GiteaMirror commented

2026-05-06 10:20:37 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/20931
Author: @Classic298
Created: 1/25/2026
Status: ✅ Merged
Merged: 1/26/2026
Merged by: @tjbck

Base: dev ← Head: fix-expunge

📝 Commits (1)

1e4694d fix: remove invalid expunge call on Pydantic FileModel

📊 Changes

1 file changed (+3 additions, -4 deletions)

View changed files

📝 backend/open_webui/routers/retrieval.py (+3 -4)

📄 Description

fix: remove invalid expunge call on Pydantic FileModel Files.get_file_by_id() returns a Pydantic FileModel, not an SQLAlchemy ORM object. Calling db.expunge() on a Pydantic model fails with UnmappedInstanceError since it lacks _sa_instance_state. The expunge was also unnecessary because subsequent DB updates already use fresh sessions via get_db() context manager.
Fixes #20925

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/20931 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 1/25/2026 **Status:** ✅ Merged **Merged:** 1/26/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix-expunge` --- ### 📝 Commits (1) - [`1e4694d`](https://github.com/open-webui/open-webui/commit/1e4694d119a641a192ff21e24183bb6d9df4f62b) fix: remove invalid expunge call on Pydantic FileModel ### 📊 Changes **1 file changed** (+3 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/retrieval.py` (+3 -4) </details> ### 📄 Description fix: remove invalid expunge call on Pydantic FileModel Files.get_file_by_id() returns a Pydantic FileModel, not an SQLAlchemy ORM object. Calling db.expunge() on a Pydantic model fails with UnmappedInstanceError since it lacks _sa_instance_state. The expunge was also unnecessary because subsequent DB updates already use fresh sessions via get_db() context manager. Fixes #20925 ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-06 10:20:37 -05:00

GiteaMirror closed this issue

2026-05-06 10:20:41 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#64695