[PR #20574] [MERGED] fix(db): release connection before embedding in knowledge /{id}/update #64535

New Issue

GiteaMirror · 2026-05-06T10:08:37-05:00

GiteaMirror commented

2026-05-06 10:08:37 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/20574
Author: @Classic298
Created: 1/11/2026
Status: ✅ Merged
Merged: 1/11/2026
Merged by: @tjbck

Base: dev ← Head: fix/db-pool-knowledge-update

📝 Commits (1)

09c0c3c fix(db): release connection before embedding in knowledge /{id}/update

📊 Changes

1 file changed (+8 additions, -6 deletions)

View changed files

📝 backend/open_webui/routers/knowledge.py (+8 -6)

📄 Description

Remove Depends(get_session) from POST /{id}/update endpoint to prevent database connections from being held during embedding API calls (1-5+ seconds).

All database operations (get_knowledge_by_id, has_access, has_permission, update_knowledge_by_id, get_file_metadatas_by_id) manage their own short-lived sessions internally, releasing connections before and after the slow embed_knowledge_base_metadata() call.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/20574 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 1/11/2026 **Status:** ✅ Merged **Merged:** 1/11/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/db-pool-knowledge-update` --- ### 📝 Commits (1) - [`09c0c3c`](https://github.com/open-webui/open-webui/commit/09c0c3c6732e2c0ce06790b9dd06f2dbc8216b15) fix(db): release connection before embedding in knowledge /{id}/update ### 📊 Changes **1 file changed** (+8 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/knowledge.py` (+8 -6) </details> ### 📄 Description Remove Depends(get_session) from POST /{id}/update endpoint to prevent database connections from being held during embedding API calls (1-5+ seconds). All database operations (get_knowledge_by_id, has_access, has_permission, update_knowledge_by_id, get_file_metadatas_by_id) manage their own short-lived sessions internally, releasing connections before and after the slow embed_knowledge_base_metadata() call. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-06 10:08:37 -05:00

GiteaMirror closed this issue

2026-05-06 10:08:39 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#64535