[PR #19680] [MERGED] perf: Update milvus_multitenancy remove flush #64162

New Issue

GiteaMirror · 2026-05-06T09:31:27-05:00

GiteaMirror commented

2026-05-06 09:31:27 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/19680
Author: @Classic298
Created: 12/2/2025
Status: ✅ Merged
Merged: 12/2/2025
Merged by: @tjbck

Base: dev ← Head: patch-1

📝 Commits (1)

ddcb1b0 Update milvus_multitenancy.py

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 backend/open_webui/retrieval/vector/dbs/milvus_multitenancy.py (+0 -1)

📄 Description

Description

Calling collection.flush() after every upsert creates severe performance bottlenecks and causes 'Rate limit exceeded' errors on standard Milvus configurations. It also leads to the 'small file problem' in MinIO/S3 and puts unnecessary load on etcd. Milvus handles persistence automatically via WAL and auto-flush policies. Removing manual flush allows Milvus to manage segments more efficiently.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/19680 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 12/2/2025 **Status:** ✅ Merged **Merged:** 12/2/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`ddcb1b0`](https://github.com/open-webui/open-webui/commit/ddcb1b0fd531692578ac887cf525062a35c7bf2b) Update milvus_multitenancy.py ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/vector/dbs/milvus_multitenancy.py` (+0 -1) </details> ### 📄 Description ### Description Calling `collection.flush()` after every upsert creates severe performance bottlenecks and causes 'Rate limit exceeded' errors on standard Milvus configurations. It also leads to the 'small file problem' in MinIO/S3 and puts unnecessary load on etcd. Milvus handles persistence automatically via WAL and auto-flush policies. Removing manual flush allows Milvus to manage segments more efficiently. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-06 09:31:27 -05:00

GiteaMirror closed this issue

2026-05-06 09:31:32 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#64162