[PR #18652] [CLOSED] fix: Function/Pipeline valves not triggered for async chat completition #63725

New Issue

GiteaMirror · 2026-05-06T08:42:11-05:00

GiteaMirror commented

2026-05-06 08:42:11 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/18652
Author: @YetheSamartaka
Created: 10/27/2025
Status: ❌ Closed

Base: dev ← Head: main

📝 Commits (2)

0b45fc9 Function/Pipeline valves not triggered for async chat completition
fbb1cf7 resolved merge conflicts with dev branch

📊 Changes

2 files changed (+141 additions, -56 deletions)

View changed files

📝 backend/open_webui/utils/middleware.py (+136 -12)
📝 src/lib/components/chat/Chat.svelte (+5 -44)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch may lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code:: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review and manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

When multiple chats were opened simultaneously, their completions finished asynchronously in the background without triggering Filters or Pipelines events. This caused missed post-processing steps (source enrichment, analytics, or message updates) because the chatCompleted handler was only called client-side - and only for the currently active chat.

How I fixed it:

Moved the chatCompleted call from the frontend (Chat.svelte) to the backend middleware. This was inherent flaw in the whole design which this PR is fixing.
Now, chat_completed() is invoked automatically after every chat finishes, regardless of whether it completes in the background or while another chat is active.

Fixed

Function/Pipeline valves not triggered for async chat completition (https://github.com/open-webui/open-webui/issues/18530)

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/18652 **Author:** [@YetheSamartaka](https://github.com/YetheSamartaka) **Created:** 10/27/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `main` --- ### 📝 Commits (2) - [`0b45fc9`](https://github.com/open-webui/open-webui/commit/0b45fc910fc0c4878daea1b45664fa61df58d4a8) Function/Pipeline valves not triggered for async chat completition - [`fbb1cf7`](https://github.com/open-webui/open-webui/commit/fbb1cf7a7e2912de46aff94b5af1c33fa9fd6465) resolved merge conflicts with dev branch ### 📊 Changes **2 files changed** (+141 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/middleware.py` (+136 -12) 📝 `src/lib/components/chat/Chat.svelte` (+5 -44) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. Not targeting the `dev` branch may lead to immediate closure of the PR. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description. - [x] **Agentic AI Code:**: Confirm this Pull Request is **not written by any AI Agent** or has at least gone through additional human review **and** manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description When multiple chats were opened simultaneously, their completions finished asynchronously in the background without triggering Filters or Pipelines events. This caused missed post-processing steps (source enrichment, analytics, or message updates) because the chatCompleted handler was only called client-side - and only for the currently active chat. How I fixed it: Moved the chatCompleted call from the frontend (Chat.svelte) to the backend middleware. This was inherent flaw in the whole design which this PR is fixing. Now, chat_completed() is invoked automatically after every chat finishes, regardless of whether it completes in the background or while another chat is active. ### Fixed - Function/Pipeline valves not triggered for async chat completition (https://github.com/open-webui/open-webui/issues/18530) ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-06 08:42:11 -05:00

GiteaMirror closed this issue

2026-05-06 08:42:17 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#63725