[PR #18304] [CLOSED] feat: done=true using chat:message:update #63603

New Issue

GiteaMirror · 2026-05-06T08:29:42-05:00

GiteaMirror commented

2026-05-06 08:29:42 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/18304
Author: @varunkhanna96
Created: 10/13/2025
Status: ❌ Closed

Base: dev ← Head: main

📝 Commits (1)

1796793 Update Chat.svelte

📊 Changes

1 file changed (+13 additions, -0 deletions)

View changed files

📝 src/lib/components/chat/Chat.svelte (+13 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch may lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code:: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review and manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Implements client-side logic to properly close the "Thinking..." or tool-call blocks when an operation is complete, using the done=True flag from the chat:message:update SSE event.

Added

New client-side logic to listen for the chat:message:update event and handle the done attribute.

Changed

N/A

Deprecated

N/A

Removed

N/A

Fixed

Fixes the issue where "Thinking..." blocks would remain animated and open after a tool-call or process finished.

Security

N/A

Breaking Changes

BREAKING CHANGE: N/A

Additional Information

This change completes the client-side handling for messages that involve a temporary "Thinking..." state, aligning the frontend's visual state with the backend's completion status (done flag).

Screenshots or Videos

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/18304 **Author:** [@varunkhanna96](https://github.com/varunkhanna96) **Created:** 10/13/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `main` --- ### 📝 Commits (1) - [`1796793`](https://github.com/open-webui/open-webui/commit/17967934626f07f140919b338aabae61931136d0) Update Chat.svelte ### 📊 Changes **1 file changed** (+13 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Chat.svelte` (+13 -0) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. Not targeting the `dev` branch may lead to immediate closure of the PR. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description. - [x] **Agentic AI Code:**: Confirm this Pull Request is **not written by any AI Agent** or has at least gone through additional human review **and** manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Implements client-side logic to properly close the "Thinking..." or tool-call blocks when an operation is complete, using the done=True flag from the chat:message:update SSE event. ### Added - New client-side logic to listen for the chat:message:update event and handle the done attribute. ### Changed - N/A ### Deprecated - N/A ### Removed - N/A ### Fixed - Fixes the issue where "Thinking..." blocks would remain animated and open after a tool-call or process finished. ### Security - N/A ### Breaking Changes - **BREAKING CHANGE**: N/A --- ### Additional Information - This change completes the client-side handling for messages that involve a temporary "Thinking..." state, aligning the frontend's visual state with the backend's completion status (done flag). ### Screenshots or Videos - <img width="402" height="75" alt="Screenshot 2025-10-13 at 9 58 06 PM" src="https://github.com/user-attachments/assets/c1977459-2643-46fd-ae68-dcac19c9f1a1" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-06 08:29:42 -05:00

GiteaMirror closed this issue

2026-05-06 08:29:44 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#63603