[PR #17933] [CLOSED] fix: keep tool result from triggering addition of rag template #63461

New Issue

GiteaMirror · 2026-05-06T08:14:53-05:00

GiteaMirror commented

2026-05-06 08:14:53 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/17933
Author: @kjpoccia
Created: 9/30/2025
Status: ❌ Closed

Base: dev ← Head: rag-template

📝 Commits (1)

8fab6ad Fix to keep all tool results from triggering rag template

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 backend/open_webui/utils/middleware.py (+3 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

In v0.6.32, a regression was introduced where tool results are incorrectly treated as RAG document sources. This causes the RAG template to be injected into the system prompt whenever external tools are invoked, even when tool outputs are not document chunks from a knowledge base.
This conflates two distinct concepts:
Document retrieval from a knowledge base (should use RAG template)
Tool execution results from function calls (should NOT use RAG template)

This fix adds back in the check for whether the returned sources are tool results.

Added

None

Changed

None

Deprecated

None

Removed

None

Fixed

Tool result check to distinguish between document sources and tool results

Security

None

Breaking Changes

None

Additional Information

None

Screenshots or Videos

None

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/17933 **Author:** [@kjpoccia](https://github.com/kjpoccia) **Created:** 9/30/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `rag-template` --- ### 📝 Commits (1) - [`8fab6ad`](https://github.com/open-webui/open-webui/commit/8fab6adaa8561fce97f8a5550ca60f58516395c9) Fix to keep all tool results from triggering rag template ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/middleware.py` (+3 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Have you written and run sufficient tests to validate the changes? - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description In v0.6.32, a regression was introduced where tool results are incorrectly treated as RAG document sources. This causes the RAG template to be injected into the system prompt whenever external tools are invoked, even when tool outputs are not document chunks from a knowledge base. This conflates two distinct concepts: Document retrieval from a knowledge base (should use RAG template) Tool execution results from function calls (should NOT use RAG template) This fix adds back in the check for whether the returned sources are tool results. ### Added None ### Changed None ### Deprecated None ### Removed None ### Fixed - Tool result check to distinguish between document sources and tool results ### Security None ### Breaking Changes None --- ### Additional Information None ### Screenshots or Videos None ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-06 08:14:53 -05:00

GiteaMirror closed this issue

2026-05-06 08:14:56 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#63461