[PR #17769] [MERGED] Fix: milvus error because the limit set to None by default #63396

New Issue

GiteaMirror · 2026-05-06T08:08:14-05:00

GiteaMirror commented

2026-05-06 08:08:14 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/17769
Author: @Classic298
Created: 9/26/2025
Status: ✅ Merged
Merged: 9/26/2025
Merged by: @tjbck

Base: dev ← Head: fix-milvus-limit-error

📝 Commits (3)

598282c Merge pull request #17747 from open-webui/dev
e7ccaf6 Fix: milvus error because the limit set to None by default
b550d78 Merge branch 'open-webui:main' into fix-milvus-limit-error

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 backend/open_webui/retrieval/vector/dbs/milvus.py (+3 -3)

📄 Description

The pymilvus library expects -1 for unlimited queries, but the code was passing None, which caused a TypeError. This commit changes the default value of the limit parameter in the query method from None to -1. It also updates the call site in the get method to pass -1 instead of None and updates the type hint and a comment to reflect this change.

Related: https://github.com/open-webui/open-webui/issues/17088

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/17769 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 9/26/2025 **Status:** ✅ Merged **Merged:** 9/26/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix-milvus-limit-error` --- ### 📝 Commits (3) - [`598282c`](https://github.com/open-webui/open-webui/commit/598282cf75de358215d045c617e70d28bc48929e) Merge pull request #17747 from open-webui/dev - [`e7ccaf6`](https://github.com/open-webui/open-webui/commit/e7ccaf6e78ee8d5adf617b953578efdd01998bbd) Fix: milvus error because the limit set to None by default - [`b550d78`](https://github.com/open-webui/open-webui/commit/b550d78905ed7a3557ba3ce00f99758a13ce4405) Merge branch 'open-webui:main' into fix-milvus-limit-error ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/vector/dbs/milvus.py` (+3 -3) </details> ### 📄 Description The pymilvus library expects -1 for unlimited queries, but the code was passing None, which caused a TypeError. This commit changes the default value of the limit parameter in the query method from None to -1. It also updates the call site in the get method to pass -1 instead of None and updates the type hint and a comment to reflect this change. Related: https://github.com/open-webui/open-webui/issues/17088 ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-06 08:08:14 -05:00

GiteaMirror closed this issue

2026-05-06 08:08:19 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#63396