[PR #16905] [CLOSED] fix: eliminate duplicate query generation in web search functionality #63132

New Issue

GiteaMirror · 2026-05-06T07:43:41-05:00

GiteaMirror commented

2026-05-06 07:43:41 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/16905
Author: @jmleksan
Created: 8/25/2025
Status: ❌ Closed

Base: dev ← Head: reuse-queries

📝 Commits (4)

407dc9a Merge pull request #16507 from open-webui/dev
2777bab Merge pull request #16810 from open-webui/dev
1db8dec Merge pull request #16821 from open-webui/dev
7a032c0 Reuse Web Search queries when available

📊 Changes

1 file changed (+30 additions, -23 deletions)

View changed files

📝 backend/open_webui/utils/middleware.py (+30 -23)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Fixed duplicate query generation in web search functionality by reusing existing queries from web search results instead of generating new ones for the same content. This eliminates redundant LLM calls and improves performance.

Added

Query reuse logic in chat_completion_files_handler to check for existing web search queries
Performance optimization using next() generator expression for efficient file filtering

Changed

Modified chat_completion_files_handler to prioritize reusing web search queries over generating new ones
Updated logging to use log.info for query reuse events for better visibility

Deprecated

None

Removed

None

Fixed

Bug: Eliminated duplicate generate_queries calls when web search is enabled
Performance: Reduced unnecessary LLM API calls for query generation
Logic: Fixed redundant processing of web search results in file handler

Security

None

Breaking Changes

None: This is a bug fix that maintains backward compatibility

Additional Information

Root Cause: The chat_completion_files_handler was processing web search results as files and generating new queries, even though the web search handler had already generated queries for the same content.
Solution: Added logic to detect web search files with existing queries and reuse them instead of generating new ones.
Impact: Reduces API costs, improves response times, and eliminates redundant processing.
Testing: The fix maintains all existing functionality while preventing the duplicate query generation issue.

Screenshots or Videos

Not applicable (backend performance fix)

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Changelog

Fixed duplicate query generation in web search functionality by reusing existing queries instead of generating new ones, eliminating redundant LLM API calls and improving performance

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/16905 **Author:** [@jmleksan](https://github.com/jmleksan) **Created:** 8/25/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `reuse-queries` --- ### 📝 Commits (4) - [`407dc9a`](https://github.com/open-webui/open-webui/commit/407dc9a401fc2382df06d776dbd8ba95dffda38a) Merge pull request #16507 from open-webui/dev - [`2777bab`](https://github.com/open-webui/open-webui/commit/2777bab1485aad097aa41c44a76f49be141eb061) Merge pull request #16810 from open-webui/dev - [`1db8dec`](https://github.com/open-webui/open-webui/commit/1db8dec4f52fc0fa8f8f7bfbb8ea5bde41fee17d) Merge pull request #16821 from open-webui/dev - [`7a032c0`](https://github.com/open-webui/open-webui/commit/7a032c0bb108bf23d84f086afb1e343a9fa85613) Reuse Web Search queries when available ### 📊 Changes **1 file changed** (+30 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/middleware.py` (+30 -23) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Fixed duplicate query generation in web search functionality by reusing existing queries from web search results instead of generating new ones for the same content. This eliminates redundant LLM calls and improves performance. ### Added - Query reuse logic in `chat_completion_files_handler` to check for existing web search queries - Performance optimization using `next()` generator expression for efficient file filtering ### Changed - Modified `chat_completion_files_handler` to prioritize reusing web search queries over generating new ones - Updated logging to use `log.info` for query reuse events for better visibility ### Deprecated - None ### Removed - None ### Fixed - **Bug**: Eliminated duplicate `generate_queries` calls when web search is enabled - **Performance**: Reduced unnecessary LLM API calls for query generation - **Logic**: Fixed redundant processing of web search results in file handler ### Security - None ### Breaking Changes - **None**: This is a bug fix that maintains backward compatibility --- ### Additional Information - **Root Cause**: The `chat_completion_files_handler` was processing web search results as files and generating new queries, even though the web search handler had already generated queries for the same content. - **Solution**: Added logic to detect web search files with existing queries and reuse them instead of generating new ones. - **Impact**: Reduces API costs, improves response times, and eliminates redundant processing. - **Testing**: The fix maintains all existing functionality while preventing the duplicate query generation issue. ### Screenshots or Videos - Not applicable (backend performance fix) ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- ## Changelog - Fixed duplicate query generation in web search functionality by reusing existing queries instead of generating new ones, eliminating redundant LLM API calls and improving performance --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-06 07:43:41 -05:00

GiteaMirror closed this issue

2026-05-06 07:43:44 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#63132