[PR #16109] [MERGED] fix: remove orientation specifier, respect OS level rotation #62887

Closed
opened 2026-05-06 07:20:44 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/16109
Author: @amoshydra
Created: 7/28/2025
Status: Merged
Merged: 7/29/2025
Merged by: @tjbck

Base: devHead: pwa-remove-orientation-member


📝 Commits (1)

  • 56a094a fix(pwa): remove orientation specifier, respect OS level rotation

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 backend/open_webui/main.py (+0 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

PWA - Remove orientation specifier (currently: any), allowing the PWA to follow OS's rotation setting.

When not specified, the orientation will uses default.

Note that not specifying is different from natural.

Added

Changed

Deprecated

Removed

Fixed

  • Fix PWA rotation issue, allow it to follow system rotation

Security

Breaking Changes


Additional Information

  • This PR attempts to resolve #13949

Screenshots or Videos

Before

https://github.com/user-attachments/assets/c6799674-67bc-42c9-82dc-a5204f0e7f37

The video above shows behaviour from 0.6.18 where orientation is set to any
In this video, the device rotation is locked, however PWA does not respect the device rotation

After

https://github.com/user-attachments/assets/f41a488b-3ecc-4475-9bea-440652a207cc

The video above shows behaviour when orientation is removed with rotation locked

  • The first part of the video, the device rotation is locked in the system setting
  • PWA orientation remains in portrait mode as the device is rotated
  • Android shows a "change rotation" hint at the bottom right corner when orientation is changed
  • Upon clicking on "change rotation" hint, PWA follows the new rotation

https://github.com/user-attachments/assets/94c5c6da-1884-4395-b370-0790f9625e00

The video above shows behaviour when orientation is removed with rotation unlocked

  • The second part of the video shows PWA behaviour with device rotation unlocked.
  • PWA follow system rotation (notice that system prevent rotation into reversed portrait even in rotation unlocked mode.)

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/16109 **Author:** [@amoshydra](https://github.com/amoshydra) **Created:** 7/28/2025 **Status:** ✅ Merged **Merged:** 7/29/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `pwa-remove-orientation-member` --- ### 📝 Commits (1) - [`56a094a`](https://github.com/open-webui/open-webui/commit/56a094a34ab0275c84044198a825cf4111ee3bbf) fix(pwa): remove orientation specifier, respect OS level rotation ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/main.py` (+0 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description PWA - Remove orientation specifier (currently: [`any`](https://w3c.github.io/screen-orientation/#dfn-any)), allowing the PWA to follow OS's rotation setting. When not specified, the orientation will uses [`default`](https://w3c.github.io/screen-orientation/#dfn-default-screen-orientation). Note that not specifying is different from [`natural`](https://w3c.github.io/screen-orientation/#dfn-natural). ### Added ### Changed ### Deprecated ### Removed ### Fixed - Fix PWA rotation issue, allow it to follow system rotation ### Security ### Breaking Changes --- ### Additional Information - This PR attempts to resolve #13949 ### Screenshots or Videos #### Before https://github.com/user-attachments/assets/c6799674-67bc-42c9-82dc-a5204f0e7f37 The video above shows behaviour from 0.6.18 where orientation is set to `any` In this video, the device rotation is locked, however PWA does not respect the device rotation #### After https://github.com/user-attachments/assets/f41a488b-3ecc-4475-9bea-440652a207cc The video above shows behaviour when orientation is removed with rotation locked - The first part of the video, the device rotation is locked in the system setting - PWA orientation remains in portrait mode as the device is rotated - Android shows a "change rotation" hint at the bottom right corner when orientation is changed - Upon clicking on "change rotation" hint, PWA follows the new rotation https://github.com/user-attachments/assets/94c5c6da-1884-4395-b370-0790f9625e00 The video above shows behaviour when orientation is removed with rotation unlocked - The second part of the video shows PWA behaviour with device rotation unlocked. - PWA follow system rotation (notice that system prevent rotation into reversed portrait even in rotation unlocked mode.) ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 07:20:44 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#62887