[PR #15407] [MERGED] refac: Increase banners height limit #62668

Closed
opened 2026-05-06 06:58:18 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/15407
Author: @silentoplayz
Created: 6/30/2025
Status: Merged
Merged: 6/30/2025
Merged by: @tjbck

Base: devHead: bannerlengthincrease


📝 Commits (1)

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/lib/components/common/Banner.svelte (+1 -1)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • This PR addresses a user's described issue posted as a comment in #14998.

Changed

  • max-h-20 -> max-h-60

Additional Information

Hello @silentoplayz and @tjbck,

according to this issue, long banners are considered a "bug". And it has been fixed with a fixed height of "max-h-20" in commit https://github.com/open-webui/open-webui/commit/afca606063900d0de46c1cb19ae8f58e7a8dfff0
The fix is working and now we are having a problem that the banners are way too short.
In our team we have to add a banner which tells our members the do's and don'ts with open webui.

As you can see in the attached picture, the size of the banner is completely fine size-wise.
Image

Compared to the new restricted height in open webui 0.6.15
We require multiple banners spanning further across the monitor. As well as looking rather bad in the UI.
Image

In my opinion the new height restriction is too limiting and should be at least increased by a fair amount.
Banners are only set by admins and therefore should not be spanning the entire monitor.
If so this is clearly a missuse on the side of the admin.

Can you please look into that and maybe re-evaluate the change?

Greetings
kns

Originally posted by @kns-12 in #14998

Screenshots or Videos

I tested with a copy/pasted response from an LLM as a banner and it turned out to be 11 lines of text used in the banner without a scrollbar.
image
The increased height limit for banners can accommodate for up to 15 lines of text used in the banner before a scrollbar is created for any extra lines of text.
image

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/15407 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 6/30/2025 **Status:** ✅ Merged **Merged:** 6/30/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `bannerlengthincrease` --- ### 📝 Commits (1) - [`9813019`](https://github.com/open-webui/open-webui/commit/9813019489944e2690cc91fa7ef5454347dc544b) Update Banner.svelte ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/common/Banner.svelte` (+1 -1) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - This PR addresses a user's described issue posted as a comment in [#14998](https://github.com/open-webui/open-webui/issues/14998#issuecomment-3019030931). ### Changed - `max-h-20` -> `max-h-60` ### Additional Information > Hello @silentoplayz and @tjbck, > > according to this issue, long banners are considered a "bug". And it has been fixed with a fixed height of "max-h-20" in commit https://github.com/open-webui/open-webui/commit/afca606063900d0de46c1cb19ae8f58e7a8dfff0 > The fix is working and now we are having a problem that the banners are way too short. > In our team we have to add a banner which tells our members the do's and don'ts with open webui. > > As you can see in the attached picture, the size of the banner is completely fine size-wise. > ![Image](https://github.com/user-attachments/assets/81f8f02b-29c7-42ad-980d-1999f478ae78) > > Compared to the new restricted height in open webui 0.6.15 > We require multiple banners spanning further across the monitor. As well as looking rather bad in the UI. > ![Image](https://github.com/user-attachments/assets/c0c1fa06-04d6-4e8b-96bf-aecac826f1bc) > > In my opinion the new height restriction is too limiting and should be at least increased by a fair amount. > Banners are only set by admins and therefore should not be spanning the entire monitor. > If so this is clearly a missuse on the side of the admin. > > Can you please look into that and maybe re-evaluate the change? > > Greetings > kns _Originally posted by @kns-12 in [#14998](https://github.com/open-webui/open-webui/issues/14998#issuecomment-3019030931)_ ### Screenshots or Videos I tested with a copy/pasted response from an LLM as a banner and it turned out to be 11 lines of text used in the banner without a scrollbar. ![image](https://github.com/user-attachments/assets/7c22f5ae-c17f-4dbb-9618-5f952fe15517) The increased height limit for banners can accommodate for up to 15 lines of text used in the banner before a scrollbar is created for any extra lines of text. ![image](https://github.com/user-attachments/assets/53cc79d4-847d-472d-a3b8-30076be5b885) ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 06:58:18 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#62668