[PR #15323] [CLOSED] feat/improved-non-chat-model-substrings #62648

New Issue

GiteaMirror · 2026-05-06T06:56:14-05:00

GiteaMirror commented

2026-05-06 06:56:14 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/15323
Author: @oloflarsson
Created: 6/26/2025
Status: ❌ Closed

Base: dev ← Head: feat/improved-non-chat-model-substrings

📝 Commits (1)

548bbaf feat/improved-non-chat-model-substrings

📊 Changes

1 file changed (+25 additions, -16 deletions)

View changed files

📝 backend/open_webui/routers/openai.py (+25 -16)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

In Short
This merge request enhances the model substring blacklist by consolidating duplicated code, adding new exclusions for non-chat models (e.g., image generators and embeddings), and ensuring consistency. It’s a non-breaking improvement between a feature and a minor bug fix.

Further Explanation
Previously, the blacklist was duplicated in the code and excluded models like Babbage, DALL-E, and Whisper. Now, we’ve:

Extracted the blacklist into a single constant to avoid repetition.
Added substrings for additional non-chat models that should be excluded, such as image generators, embeddings, and rerankers.

Examples of New Exclusions
The updated blacklist now excludes models like:

BAAI and BGE Reranker.
Play AI TTS (due to the "TTS" substring).
Black Forest Labs, Flux Schnell, and Flux Dev.
E5 (from Intfloat E5 Mistral).
SDXL (from Stability AI).

Why This Matters
With the new feature supporting multiple OpenAI connections, refining this blacklist ensures irrelevant models (e.g., non-chat utilities) are consistently hidden, improving user experience.

Added

none

Changed

This merge request enhances the model substring blacklist by consolidating duplicated code, adding new exclusions for non-chat models (e.g., image generators and embeddings), and ensuring consistency.

Deprecated

none

Removed

none

Fixed

none

Security

none

Breaking Changes

none

Additional Information

[Insert any additional context, notes, or explanations for the changes]
- [Reference any related issues, commits, or other relevant information]

Screenshots or Videos

[Attach any relevant screenshots or videos demonstrating the changes]

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/15323 **Author:** [@oloflarsson](https://github.com/oloflarsson) **Created:** 6/26/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `feat/improved-non-chat-model-substrings` --- ### 📝 Commits (1) - [`548bbaf`](https://github.com/open-webui/open-webui/commit/548bbaf501a340fc9cfcdd18a3ca2695ef561179) feat/improved-non-chat-model-substrings ### 📊 Changes **1 file changed** (+25 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/openai.py` (+25 -16) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests to validate the changes? - [ ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description **In Short** This merge request enhances the model substring blacklist by consolidating duplicated code, adding new exclusions for non-chat models (e.g., image generators and embeddings), and ensuring consistency. It’s a non-breaking improvement between a feature and a minor bug fix. **Further Explanation** Previously, the blacklist was duplicated in the code and excluded models like Babbage, DALL-E, and Whisper. Now, we’ve: - Extracted the blacklist into a single constant to avoid repetition. - Added substrings for additional non-chat models that should be excluded, such as image generators, embeddings, and rerankers. **Examples of New Exclusions** The updated blacklist now excludes models like: - BAAI and BGE Reranker. - Play AI TTS (due to the "TTS" substring). - Black Forest Labs, Flux Schnell, and Flux Dev. - E5 (from Intfloat E5 Mistral). - SDXL (from Stability AI). **Why This Matters** With the new feature supporting multiple OpenAI connections, refining this blacklist ensures irrelevant models (e.g., non-chat utilities) are consistently hidden, improving user experience. ### Added none ### Changed This merge request enhances the model substring blacklist by consolidating duplicated code, adding new exclusions for non-chat models (e.g., image generators and embeddings), and ensuring consistency. ### Deprecated none ### Removed none ### Fixed none ### Security none ### Breaking Changes none --- ### Additional Information - [Insert any additional context, notes, or explanations for the changes] - [Reference any related issues, commits, or other relevant information] ### Screenshots or Videos - [Attach any relevant screenshots or videos demonstrating the changes] ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-06 06:56:14 -05:00

GiteaMirror closed this issue

2026-05-06 06:56:16 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#62648