[PR #15060] [CLOSED] fix: resolve placeholder not updating in sequential __event_call__ prompts (#14927) #62554

New Issue

GiteaMirror · 2026-05-06T06:45:22-05:00

GiteaMirror commented

2026-05-06 06:45:22 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/15060
Author: @jackthgu
Created: 6/17/2025
Status: ❌ Closed

Base: dev ← Head: issue_14927_clean

📝 Commits (1)

086365b fix: resolve placeholder not updating in sequential event_call prompts (#14927)

📊 Changes

1 file changed (+7 additions, -2 deletions)

View changed files

📝 src/lib/components/common/ConfirmDialog.svelte (+7 -2)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

In Svelte, the parent (Chat.svelte) passed a prop (inputValue) to the child (ConfirmDialog.svelte), but the child used bind:value for two-way binding. This caused the child's input to directly mutate the parent's state.
The child component now uses an internal state (internalInputValue) for the textarea binding, separate from the prop.
The internal state is initialized from the prop when the dialog opens, and only sent to the parent via event on confirmation.

Added

None

Changed

ConfirmDialog.svelte: Separated prop (inputValue) and internal state (internalInputValue), updated binding logic.

Deprecated

None

Removed

None

Fixed

Fixed a bug where the parent's state was unintentionally changed by the child due to two-way binding (#14927).

Security

None

Breaking Changes

None

Additional Information

Related issue: [GH-ISSUE #7908] Resizable Chat-Overview Sidebar (Left) for Better Visibility of Long Titles (#14927)

Screenshots or Videos

(N/A)

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/15060 **Author:** [@jackthgu](https://github.com/jackthgu) **Created:** 6/17/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `issue_14927_clean` --- ### 📝 Commits (1) - [`086365b`](https://github.com/open-webui/open-webui/commit/086365b3859cfdb505b6552e27c1f58d21e9d21b) fix: resolve placeholder not updating in sequential __event_call__ prompts (#14927) ### 📊 Changes **1 file changed** (+7 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/common/ConfirmDialog.svelte` (+7 -2) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - In Svelte, the parent (Chat.svelte) passed a prop (`inputValue`) to the child (ConfirmDialog.svelte), but the child used `bind:value` for two-way binding. This caused the child's input to directly mutate the parent's state. - The child component now uses an internal state (`internalInputValue`) for the textarea binding, separate from the prop. - The internal state is initialized from the prop when the dialog opens, and only sent to the parent via event on confirmation. ### Added - None ### Changed - ConfirmDialog.svelte: Separated prop (`inputValue`) and internal state (`internalInputValue`), updated binding logic. ### Deprecated - None ### Removed - None ### Fixed - Fixed a bug where the parent's state was unintentionally changed by the child due to two-way binding (#14927). ### Security - None ### Breaking Changes - None --- ### Additional Information - Related issue: #14927 ### Screenshots or Videos - (N/A) ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-06 06:45:22 -05:00

GiteaMirror closed this issue

2026-05-06 06:45:24 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#62554