github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-07-16 06:03:26 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #14944] [MERGED] feat: Implement Client-Side Sorting for Feedback History Table #62511

New Issue
Closed
opened 2026-05-06 06:41:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-06 06:41:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14944
Author: @silentoplayz
Created: 6/12/2025
Status: ✅ Merged
Merged: 6/16/2025
Merged by: @tjbck

Base: dev ← Head: sort-feedbacks

📝 Commits (2)

  • 380a31f Feat: Implement Client-Side Sorting for Feedback History Table
  • 5a4a293 Merge branch 'dev' into sort-feedbacks

📊 Changes

1 file changed (+130 additions, -9 deletions)

View changed files

📝 src/lib/components/admin/Evaluations/Feedbacks.svelte (+130 -9)

📄 Description

Pull Request Checklist

Before submitting, make sure you`ve checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project`s coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • This pull request introduces client-side sorting functionality to the Admin Feedback History table. Users can now click on table headers (User, Models, Result, Updated At) to sort the feedback entries in ascending or descending order. This improves the usability and navigability of the feedback history, allowing administrators to more easily review and analyze feedback.

Added

  • New sorting mechanism for the feedback history table.
  • ChevronUp and ChevronDown icons for visual sort direction indication in table headers.
  • setSortKey function to manage sort state and direction.
  • sortedFeedbacks reactive declaration to provide the sorted data for display.

Changed

  • The paginatedFeedbacks now slices from sortedFeedbacks instead of the raw feedbacks array.
  • Table headers (<th>) were updated with on:click handlers to trigger sorting.
  • Conditional rendering logic was added to table headers to display sort icons based on the orderBy and direction state.
  • Minor adjustments to table header styling to accommodate sort icons.

Additional Information

  • Sorting by User and Models defaults to asc (ascending) when first selected, while Result and Updated At default to desc (descending). Subsequent clicks on the same header toggle the direction.
  • Changing the sort order resets the pagination to the first page.
  • Related PR - https://github.com/open-webui/open-webui/pull/14868

Screenshots or Videos

image

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14944 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 6/12/2025 **Status:** ✅ Merged **Merged:** 6/16/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `sort-feedbacks` --- ### 📝 Commits (2) - [`380a31f`](https://github.com/open-webui/open-webui/commit/380a31fbacd91ca7bafe5cb5e40d2a9b8eff75a6) Feat: Implement Client-Side Sorting for Feedback History Table - [`5a4a293`](https://github.com/open-webui/open-webui/commit/5a4a293a93555e2e65665190b8c016e7ce21f8a2) Merge branch 'dev' into sort-feedbacks ### 📊 Changes **1 file changed** (+130 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/admin/Evaluations/Feedbacks.svelte` (+130 -9) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you`ve checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project`s coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - This pull request introduces client-side sorting functionality to the Admin Feedback History table. Users can now click on table headers (`User`, `Models`, `Result`, `Updated At`) to sort the feedback entries in ascending or descending order. This improves the usability and navigability of the feedback history, allowing administrators to more easily review and analyze feedback. ### Added - New sorting mechanism for the feedback history table. - `ChevronUp` and `ChevronDown` icons for visual sort direction indication in table headers. - `setSortKey` function to manage sort state and direction. - `sortedFeedbacks` reactive declaration to provide the sorted data for display. ### Changed - The `paginatedFeedbacks` now slices from `sortedFeedbacks` instead of the raw `feedbacks` array. - Table headers (`<th>`) were updated with `on:click` handlers to trigger sorting. - Conditional rendering logic was added to table headers to display sort icons based on the `orderBy` and `direction` state. - Minor adjustments to table header styling to accommodate sort icons. --- ### Additional Information - Sorting by `User` and `Models` defaults to `asc` (ascending) when first selected, while `Result` and `Updated At` default to `desc` (descending). Subsequent clicks on the same header toggle the direction. - Changing the sort order resets the pagination to the first page. - Related PR - https://github.com/open-webui/open-webui/pull/14868 ### Screenshots or Videos ![image](https://github.com/user-attachments/assets/0b90fb9a-32ab-4c0e-ad8c-7aa0f96cbfb4) ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 06:41:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#62511
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?