[PR #14683] [MERGED] chore: More ideomatic docker-build matrix #62408

New Issue

GiteaMirror · 2026-05-06T06:33:40-05:00

GiteaMirror commented

2026-05-06 06:33:40 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14683
Author: @guenhter
Created: 6/5/2025
Status: ✅ Merged
Merged: 6/5/2025
Merged by: @tjbck

Base: dev ← Head: more-ideomatic-matrix

📝 Commits (1)

0fe82d1 chore: make usage of matrix more ideomatic

📊 Changes

1 file changed (+24 additions, -16 deletions)

View changed files

📝 .github/workflows/docker-build.yaml (+24 -16)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

I wanted to improve the readability in the docker-build.yml and remove a little bit of duplication by using the matrix.include construct https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/running-variations-of-jobs-in-a-workflow#expanding-or-adding-matrix-configurations.

What it does is this:

Usually matrix makes a cross product of all options like this:

strategy:
  matrix:
    platform: [linux/amd64, linux/arm64]
    runner: [ubuntu-latest, ubuntu-24.04-arm]

gives us 4 variants:

{platform: linux/amd64, runner: ubuntu-latest }
{platform: linux/amd64, runner: ubuntu-24.04-arm }
{platform: linux/arm64, runner: ubuntu-latest }
{platform: linux/arm64, runner: ubuntu-24.04-arm }

but with the include command, we can now define tuples:

strategy:
  matrix:
    include:
      - platform: linux/amd64
        runner: ubuntu-latest
      - platform: linux/arm64
        runner: ubuntu-24.04-arm

gives us only 2 variants:

{platform: linux/amd64, runner: ubuntu-latest }
{platform: linux/arm64, runner: ubuntu-24.04-arm }

Changed

Refactored the way the runner is determined based on the platform for the docker build ci steps

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14683 **Author:** [@guenhter](https://github.com/guenhter) **Created:** 6/5/2025 **Status:** ✅ Merged **Merged:** 6/5/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `more-ideomatic-matrix` --- ### 📝 Commits (1) - [`0fe82d1`](https://github.com/open-webui/open-webui/commit/0fe82d119f18d362d27c291be26b4cbbf8874cd1) chore: make usage of matrix more ideomatic ### 📊 Changes **1 file changed** (+24 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/docker-build.yaml` (+24 -16) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description I wanted to improve the readability in the docker-build.yml and remove a little bit of duplication by using the `matrix.include` construct https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/running-variations-of-jobs-in-a-workflow#expanding-or-adding-matrix-configurations. What it does is this: Usually matrix makes a cross product of all options like this: ``` strategy: matrix: platform: [linux/amd64, linux/arm64] runner: [ubuntu-latest, ubuntu-24.04-arm] ``` gives us 4 variants: * `{platform: linux/amd64, runner: ubuntu-latest }` * `{platform: linux/amd64, runner: ubuntu-24.04-arm }` * `{platform: linux/arm64, runner: ubuntu-latest }` * `{platform: linux/arm64, runner: ubuntu-24.04-arm }` but with the `include` command, we can now define tuples: ``` strategy: matrix: include: - platform: linux/amd64 runner: ubuntu-latest - platform: linux/arm64 runner: ubuntu-24.04-arm ``` gives us only 2 variants: * `{platform: linux/amd64, runner: ubuntu-latest }` * `{platform: linux/arm64, runner: ubuntu-24.04-arm }` ### Changed - Refactored the way the runner is determined based on the platform for the docker build ci steps --- ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-06 06:33:40 -05:00

GiteaMirror closed this issue

2026-05-06 06:33:42 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#62408