[PR #14532] [MERGED] perf pinecone.py Improve Performance and Maintainability Using Current Best Practices #62352

New Issue

GiteaMirror · 2026-05-06T06:27:58-05:00

GiteaMirror commented

2026-05-06 06:27:58 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14532
Author: @PVBLIC-F
Created: 5/30/2025
Status: ✅ Merged
Merged: 6/2/2025
Merged by: @tjbck

Base: dev ← Head: refac/pinecone

📝 Commits (2)

4ecf2a8 Update pinecone.py
66bde32 Update pinecone.py

📊 Changes

1 file changed (+81 additions, -8 deletions)

View changed files

📝 backend/open_webui/retrieval/vector/dbs/pinecone.py (+81 -8)

📄 Description

May 2025 Latest Pinecone Best Practices

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Just finished Pinecone Certification. Refactoring based on May 2025 Best Practices

Added

What pinecone[grpc] Includes:

grpcio - Core gRPC protocol library
grpcio-status - Enhanced gRPC status handling
googleapis-common-protos>=1.66.0 - Google API protocol buffers
Related gRPC dependencies for optimal Pinecone performance

Note: The [grpc] extra is optional but highly recommended for production deployments to achieve maximum performance gains.

Changed

1. gRPC Client Support
Added: Automatic detection and usage of Pinecone's high-performance gRPC client
Fallback: Graceful degradation to HTTP client if gRPC unavailable
Performance: ~2x faster vector operations compared to HTTP

2. Enhanced Connection Pooling
Client Threads: Increased to 20 concurrent threads (from default)
Index Threads: Dedicated 20-thread pool for index operations
Timeouts: Optimized 30-second operation timeouts
Benefit: Better handling of concurrent document uploads and searches

3. Intelligent Retry Logic
Method: _retry_pinecone_operation() with exponential backoff + jitter
Handles: Rate limits (429), network issues, temporary server errors (500-504)
Strategy: Max 3 retries with smart error classification
Benefit: Automatic recovery from temporary Pinecone API issues

4. Enhanced Error Handling
Smart Classification: Distinguishes retryable vs non-retryable errors
Jitter: Prevents thundering herd during retry attempts
Logging: Improved debugging and monitoring visibility

Deprecated

[List any deprecated functionality or features that have been removed]

Removed

[List any removed features, files, or functionalities]

Fixed

[List any fixes, corrections, or bug fixes]

Security

[List any new or updated security-related changes, including vulnerability fixes]

Breaking Changes

BREAKING CHANGE: [List any breaking changes affecting compatibility or functionality]

Additional Information

Requirements.txt

remove pinecone==6.0.2
add pinecone[grpc]==6.0.2

remove googleapis-common-protos==1.63.2
add googleapis-common-protos>=1.66.0

Screenshots or Videos

[Attach any relevant screenshots or videos demonstrating the changes]

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14532 **Author:** [@PVBLIC-F](https://github.com/PVBLIC-F) **Created:** 5/30/2025 **Status:** ✅ Merged **Merged:** 6/2/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `refac/pinecone` --- ### 📝 Commits (2) - [`4ecf2a8`](https://github.com/open-webui/open-webui/commit/4ecf2a868553ba51f4e142fb3ba83c5abb07182d) Update pinecone.py - [`66bde32`](https://github.com/open-webui/open-webui/commit/66bde326230aa1069a6a73b18e00862d5be4316e) Update pinecone.py ### 📊 Changes **1 file changed** (+81 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/vector/dbs/pinecone.py` (+81 -8) </details> ### 📄 Description May 2025 Latest Pinecone Best Practices # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [ ] **Target branch:** Please verify that the pull request targets the `dev` branch. - [ ] **Description:** Provide a concise description of the changes made in this pull request. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests to validate the changes? - [ ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [ ] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Just finished Pinecone Certification. Refactoring based on May 2025 Best Practices ### Added **What pinecone[grpc] Includes:** grpcio - Core gRPC protocol library grpcio-status - Enhanced gRPC status handling googleapis-common-protos>=1.66.0 - Google API protocol buffers Related gRPC dependencies for optimal Pinecone performance **Note: The [grpc] extra is optional but highly recommended for production deployments to achieve maximum performance gains.** ### Changed **1. gRPC Client Support** Added: Automatic detection and usage of Pinecone's high-performance gRPC client Fallback: Graceful degradation to HTTP client if gRPC unavailable Performance: ~2x faster vector operations compared to HTTP **2. Enhanced Connection Pooling** Client Threads: Increased to 20 concurrent threads (from default) Index Threads: Dedicated 20-thread pool for index operations Timeouts: Optimized 30-second operation timeouts Benefit: Better handling of concurrent document uploads and searches **3. Intelligent Retry Logic** Method: _retry_pinecone_operation() with exponential backoff + jitter Handles: Rate limits (429), network issues, temporary server errors (500-504) Strategy: Max 3 retries with smart error classification Benefit: Automatic recovery from temporary Pinecone API issues **4. Enhanced Error Handling** Smart Classification: Distinguishes retryable vs non-retryable errors Jitter: Prevents thundering herd during retry attempts Logging: Improved debugging and monitoring visibility ### Deprecated - [List any deprecated functionality or features that have been removed] ### Removed - [List any removed features, files, or functionalities] ### Fixed - [List any fixes, corrections, or bug fixes] ### Security - [List any new or updated security-related changes, including vulnerability fixes] ### Breaking Changes - **BREAKING CHANGE**: [List any breaking changes affecting compatibility or functionality] --- ### Additional Information **Requirements.txt** **remove** pinecone==6.0.2 **add** pinecone[grpc]==6.0.2 **remove** googleapis-common-protos==1.63.2 **add** googleapis-common-protos>=1.66.0 ### Screenshots or Videos - [Attach any relevant screenshots or videos demonstrating the changes] ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-06 06:27:58 -05:00

GiteaMirror closed this issue

2026-05-06 06:28:00 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#62352