[PR #13306] [MERGED] Perf: Chat Websocket Sequential Awaits #62005

New Issue

GiteaMirror · 2026-05-06T05:50:06-05:00

GiteaMirror commented

2026-05-06 05:50:06 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/13306
Author: @tarmst
Created: 4/28/2025
Status: ✅ Merged
Merged: 4/28/2025
Merged by: @tjbck

Base: dev ← Head: remove-blocking-websocket-awaits

📝 Commits (1)

c9a9e05 Fix websocket sequential awaits

📊 Changes

1 file changed (+12 additions, -10 deletions)

View changed files

📝 backend/open_webui/socket/main.py (+12 -10)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Discussion: https://github.com/open-webui/open-webui/discussions/12856

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
- None
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- perf: Performance improvement

Changelog Entry

Description

Previously, the chat event emitter that used websockets would sequentially await the websocket emits, which caused lag when multiple users chat with the application. The following PR removes the sequential awaits, opting to group the coroutines together with a single asyncio.gather. See discussion post https://github.com/open-webui/open-webui/discussions/12856

Changed

Changed websocket event emitter to await only once all events are emitted, not one event at a time.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the CONTRIBUTOR_LICENSE_AGREEMENT, and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/13306 **Author:** [@tarmst](https://github.com/tarmst) **Created:** 4/28/2025 **Status:** ✅ Merged **Merged:** 4/28/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `remove-blocking-websocket-awaits` --- ### 📝 Commits (1) - [`c9a9e05`](https://github.com/open-webui/open-webui/commit/c9a9e05bb46e19be8df541084f2c3fb16f409cf6) Fix websocket sequential awaits ### 📊 Changes **1 file changed** (+12 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/socket/main.py` (+12 -10) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. Discussion: https://github.com/open-webui/open-webui/discussions/12856 **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - None - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **perf**: Performance improvement # Changelog Entry ### Description - Previously, the chat event emitter that used websockets would sequentially await the websocket emits, which caused lag when multiple users chat with the application. The following PR removes the sequential awaits, opting to group the coroutines together with a single asyncio.gather. See discussion post https://github.com/open-webui/open-webui/discussions/12856 ### Changed - Changed websocket event emitter to await only once all events are emitted, not one event at a time. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [CONTRIBUTOR_LICENSE_AGREEMENT](CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-06 05:50:06 -05:00

GiteaMirror closed this issue

2026-05-06 05:50:09 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#62005