[PR #11502] [CLOSED] fix: Filters not skipping files properly #61605

New Issue

GiteaMirror · 2026-05-06T05:08:17-05:00

GiteaMirror commented

2026-05-06 05:08:17 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/11502
Author: @landerrosette
Created: 3/10/2025
Status: ❌ Closed

Base: dev ← Head: fix/skip_files

📝 Commits (2)

91b77e7 fix: update file cleanup logic to directly reference 'files' key
2ceaae0 leave tool_handler untouched

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 backend/open_webui/utils/filter.py (+2 -2)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Fixes a bug in process_filter_functions where file removal targeted the incorrect key. The middleware retrieves files directly from form_data["files"] at d7bfa395b0/backend/open_webui/utils/middleware.py (L756)

Therefore, process_filter_functions called at d7bfa395b0/backend/open_webui/utils/middleware.py (L723) should delete form_data["files"], not form_data["metadata"]["files"].

Fixed

Incorrect file deletion in process_filter_functions

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/11502 **Author:** [@landerrosette](https://github.com/landerrosette) **Created:** 3/10/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/skip_files` --- ### 📝 Commits (2) - [`91b77e7`](https://github.com/open-webui/open-webui/commit/91b77e7f7a26a1cf6d090c0eeeafbf18ec1a2530) fix: update file cleanup logic to directly reference 'files' key - [`2ceaae0`](https://github.com/open-webui/open-webui/commit/2ceaae0a17f073593f0be4e8df926fcabc70d345) leave tool_handler untouched ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/filter.py` (+2 -2) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [ ] **Description:** Provide a concise description of the changes made in this pull request. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Fixes a bug in `process_filter_functions` where file removal targeted the incorrect key. The middleware retrieves files directly from `form_data["files"]` at https://github.com/open-webui/open-webui/blob/d7bfa395b0672a21a41fb6706a4275673d339762/backend/open_webui/utils/middleware.py#L756 Therefore, `process_filter_functions` called at https://github.com/open-webui/open-webui/blob/d7bfa395b0672a21a41fb6706a4275673d339762/backend/open_webui/utils/middleware.py#L723 should delete `form_data["files"]`, not `form_data["metadata"]["files"]`. ### Fixed - Incorrect file deletion in `process_filter_functions` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-06 05:08:17 -05:00

GiteaMirror closed this issue

2026-05-06 05:08:19 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#61605