[PR #11413] [MERGED] fix: Prevent modification of global filter settings in "Admin panel" - "Settings" - "Models" #61585

New Issue

GiteaMirror · 2026-05-06T05:07:08-05:00

GiteaMirror commented

2026-05-06 05:07:08 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/11413
Author: @hurxxxx
Created: 3/8/2025
Status: ✅ Merged
Merged: 3/8/2025
Merged by: @tjbck

Base: dev ← Head: fix/global-filter-cannot-disable

📝 Commits (3)

3b70cd6 Merge pull request #11257 from open-webui/dev
851931f fix: Global filter cannot be modified in the model (changes have no effect)
40257af fix: Using disabled attribute for elements is common

📊 Changes

2 files changed (+11 additions, -4 deletions)

View changed files

📝 src/lib/components/common/Checkbox.svelte (+5 -1)
📝 src/lib/components/workspace/Models/FiltersSelector.svelte (+6 -3)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

The global filter appears to be disableable in the model settings. However, according to filter.py:get_sorted_filter_ids, the global filter is always applied. Therefore, the global filter setting in the model settings cannot be modified, and the checkbox appears as true but is not actually saved.

Changed

Added the enabled option to src/lib/components/common/Checkbox.svelte.
In src/lib/components/workspace/Models/FiltersSelector.svelte, disabled the checkbox based on is_global and ensured that the activation state of the is_global filter is not saved.

Screenshots or Videos

https://github.com/user-attachments/assets/feb5b716-c060-4fba-b5dd-2ab818599715

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/11413 **Author:** [@hurxxxx](https://github.com/hurxxxx) **Created:** 3/8/2025 **Status:** ✅ Merged **Merged:** 3/8/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/global-filter-cannot-disable` --- ### 📝 Commits (3) - [`3b70cd6`](https://github.com/open-webui/open-webui/commit/3b70cd64d7fa6902e8c79cf8dcbf3c7e84cf704b) Merge pull request #11257 from open-webui/dev - [`851931f`](https://github.com/open-webui/open-webui/commit/851931fdf6d06fceed50773139e1699ffc0b6e5d) fix: Global filter cannot be modified in the model (changes have no effect) - [`40257af`](https://github.com/open-webui/open-webui/commit/40257afeed5a99802dcd8ac2a26189a6de9c43f3) fix: Using disabled attribute for elements is common ### 📊 Changes **2 files changed** (+11 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/common/Checkbox.svelte` (+5 -1) 📝 `src/lib/components/workspace/Models/FiltersSelector.svelte` (+6 -3) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - The global filter appears to be disableable in the model settings. However, according to `filter.py:get_sorted_filter_ids`, the global filter is always applied. Therefore, the global filter setting in the model settings cannot be modified, and the checkbox appears as `true` but is not actually saved. ### Changed - Added the enabled option to src/lib/components/common/Checkbox.svelte. - In src/lib/components/workspace/Models/FiltersSelector.svelte, disabled the checkbox based on is_global and ensured that the activation state of the is_global filter is not saved. ### Screenshots or Videos https://github.com/user-attachments/assets/feb5b716-c060-4fba-b5dd-2ab818599715 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-06 05:07:08 -05:00

GiteaMirror closed this issue

2026-05-06 05:07:10 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#61585