[PR #11038] [MERGED] fixed manifest in app.html restoring PWA #61503

Closed
opened 2026-05-06 05:02:48 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/11038
Author: @satlus
Created: 3/2/2025
Status: Merged
Merged: 3/2/2025
Merged by: @tjbck

Base: devHead: pwa-fix-linkrel


📝 Commits (1)

  • 6e58d99 fixed manifest link rel, restoring PWA

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/app.html (+1 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • Updated (reverted) src/app.html to refer to the backend generated manifest.json.

Added

  • None, bugfix

Changed

  • None

Deprecated

  • None

Removed

  • None

Fixed

  • Restored PWA feature

Security

  • None

Breaking Changes

  • None

Additional Information

Noticed the PWA installs no longer worked, debugged and saw the manifest.json was not properly referenced in the <link rel="manifest" href="/favicon/site.webmanifest"> in src/app.html. Edited it directly via devtools, and the install icon appeared in the browser

Screenshots or Videos

Broken (dev branch):
image

Fixed (PR)
image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/11038 **Author:** [@satlus](https://github.com/satlus) **Created:** 3/2/2025 **Status:** ✅ Merged **Merged:** 3/2/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `pwa-fix-linkrel` --- ### 📝 Commits (1) - [`6e58d99`](https://github.com/open-webui/open-webui/commit/6e58d999204b8fb6d79723dbd44ae3e7c260af75) fixed manifest link rel, restoring PWA ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/app.html` (+1 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [ ] **Description:** Provide a concise description of the changes made in this pull request. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests for validating the changes? - [ ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [ ] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Updated (reverted) src/app.html to refer to the backend generated manifest.json. ### Added - None, bugfix ### Changed - None ### Deprecated - None ### Removed - None ### Fixed - Restored PWA feature ### Security - None ### Breaking Changes - None --- ### Additional Information Noticed the PWA installs no longer worked, debugged and saw the manifest.json was not properly referenced in the `<link rel="manifest" href="/favicon/site.webmanifest">` in src/app.html. Edited it directly via devtools, and the install icon appeared in the browser ### Screenshots or Videos Broken (dev branch): ![image](https://github.com/user-attachments/assets/883c2ad2-7f4a-4cb5-b407-3ee3bcff1c37) Fixed (PR) ![image](https://github.com/user-attachments/assets/3a5b3d7b-9431-4a61-b7d6-47ff738af2ad) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 05:02:48 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#61503