[PR #2469] [MERGED] refac: consolidate chat logic into single component #59863

Closed
opened 2026-05-06 02:17:32 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/2469
Author: @cheahjs
Created: 5/21/2024
Status: Merged
Merged: 5/21/2024
Merged by: @tjbck

Base: devHead: refac/consolidate-chat-into-single-component


📝 Commits (2)

  • 5eb9b00 refac: consolidate chat logic into single component
  • 6d23799 fix: formatting

📊 Changes

3 files changed (+1061 additions, -1980 deletions)

View changed files

src/lib/components/chat/Chat.svelte (+1057 -0)
📝 src/routes/(app)/+page.svelte (+2 -983)
📝 src/routes/(app)/c/[id]/+page.svelte (+2 -997)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Label: To cleary categorize this pull request, assign a relevant label to the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

We currently duplicate almost every single line across the top-level (app)/+page.svelte and the chat specific (app)/c/[id]/+page.svelte files - which is prone to mistakes when syncing changes between the two.

This moves all of the code under a single Chat component.

Note: this is going to cause merge conflicts with any PRs that have changes to these files, but it should make future changes easier when you don't have to remember to copy the changes over to the other file.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/2469 **Author:** [@cheahjs](https://github.com/cheahjs) **Created:** 5/21/2024 **Status:** ✅ Merged **Merged:** 5/21/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `refac/consolidate-chat-into-single-component` --- ### 📝 Commits (2) - [`5eb9b00`](https://github.com/open-webui/open-webui/commit/5eb9b00f8d92aabb215281b3389ac942872c3849) refac: consolidate chat logic into single component - [`6d23799`](https://github.com/open-webui/open-webui/commit/6d237999dc1acb0a1d254b2934201402a4eada13) fix: formatting ### 📊 Changes **3 files changed** (+1061 additions, -1980 deletions) <details> <summary>View changed files</summary> ➕ `src/lib/components/chat/Chat.svelte` (+1057 -0) 📝 `src/routes/(app)/+page.svelte` (+2 -983) 📝 `src/routes/(app)/c/[id]/+page.svelte` (+2 -997) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Label:** To cleary categorize this pull request, assign a relevant label to the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description We currently duplicate almost every single line across the top-level `(app)/+page.svelte` and the chat specific `(app)/c/[id]/+page.svelte` files - which is prone to mistakes when syncing changes between the two. This moves all of the code under a single `Chat` component. Note: this is going to cause merge conflicts with any PRs that have changes to these files, but it should make future changes easier when you don't have to remember to copy the changes over to the other file. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 02:17:32 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#59863