github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-07 03:18:23 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #24244] perf: avoid redundant frontmatter dependency installs after startup preinstall #50559

New Issue
Open
opened 2026-04-30 03:20:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 03:20:27 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/24244
Author: @jmleksan
Created: 4/29/2026
Status: 🔄 Open

Base: dev ← Head: perf/function-dependency-installation

📝 Commits (1)

  • 5c23b3e perf: enhance dependency management in function loading

📊 Changes

2 files changed (+24 additions, -6 deletions)

View changed files

📝 backend/open_webui/main.py (+4 -1)
📝 backend/open_webui/utils/plugin.py (+20 -5)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch. PRs targeting main will be immediately closed.
  • Description: Provide a concise description of the changes made in this pull request down below.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Add docs in Open WebUI Docs Repository. Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps.
  • Dependencies: Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash.
    No new/upgraded dependencies in this PR.
  • Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to make screenshots of the feature/fix and include them in the PR description.
  • Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Design & Architecture: Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes.
  • Git Hygiene: Keep PRs atomic (one logical change). Clean up commits and rebase on dev to ensure no unrelated commits (e.g. from main) are included. Push updates to the existing PR branch instead of closing and reopening.
  • Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • perf

Changelog Entry

Description

  • Fix redundant dependency installation for function frontmatter requirements during first UI/model load after startup.
  • Preserve runtime safety by still allowing dependency installation when function content changes or when a function was not part of startup preinstall.

Added

  • App state tracking for dependency preinstall completion and preinstalled function IDs:
    • dependencies_preinstalled
    • preinstalled_function_ids

Changed

  • install_tool_and_function_dependencies() now returns the set of function IDs included in startup preinstall.
  • Function module loading now conditionally installs frontmatter requirements instead of always running pip install on load.

Fixed

  • Prevents repeated per-function pip install calls on first /api/models / UI connection when dependencies were already installed during startup preinstall.
  • Reduces first-traffic latency and repeated "Requirement already satisfied" installation churn in logs.

Additional Information

  • Motivation: in cold-start environments (e.g., new pods), startup already performs dependency preinstall, but first model/function load still triggered frontmatter installs per function, causing avoidable latency.
  • Behavior after fix:
    • Skip runtime frontmatter install when startup preinstall has completed and function content is unchanged and the function was included in startup preinstall.
    • Still install at runtime if:
      • startup preinstall has not completed,
      • function content changed,
      • function was not part of startup preinstall.

Contributor License Agreement

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/24244 **Author:** [@jmleksan](https://github.com/jmleksan) **Created:** 4/29/2026 **Status:** 🔄 Open **Base:** `dev` ← **Head:** `perf/function-dependency-installation` --- ### 📝 Commits (1) - [`5c23b3e`](https://github.com/open-webui/open-webui/commit/5c23b3e7a05362f4fef9ddef07db724382d9c7b7) perf: enhance dependency management in function loading ### 📊 Changes **2 files changed** (+24 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/main.py` (+4 -1) 📝 `backend/open_webui/utils/plugin.py` (+20 -5) </details> ### 📄 Description <!-- ⚠️ CRITICAL CHECKS FOR CONTRIBUTORS (READ, DON'T DELETE) ⚠️ 1. Target the `dev` branch. PRs targeting `main` will be automatically closed. 2. Do NOT delete the CLA section at the bottom. It is required for the bot to accept your PR. --> # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **PRs targeting `main` will be immediately closed.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Add docs in [Open WebUI Docs Repository](https://github.com/open-webui/docs). Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps. - [x] **Dependencies:** Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash. No new/upgraded dependencies in this PR. - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to **make screenshots of the feature/fix and include them in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Design & Architecture:** Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes. - [x] **Git Hygiene:** Keep PRs atomic (one logical change). Clean up commits and rebase on `dev` to ensure no unrelated commits (e.g. from `main`) are included. Push updates to the existing PR branch instead of closing and reopening. - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **perf** # Changelog Entry ### Description - Fix redundant dependency installation for function frontmatter requirements during first UI/model load after startup. - Preserve runtime safety by still allowing dependency installation when function content changes or when a function was not part of startup preinstall. ### Added - App state tracking for dependency preinstall completion and preinstalled function IDs: - `dependencies_preinstalled` - `preinstalled_function_ids` ### Changed - `install_tool_and_function_dependencies()` now returns the set of function IDs included in startup preinstall. - Function module loading now conditionally installs frontmatter requirements instead of always running `pip install` on load. ### Fixed - Prevents repeated per-function `pip install` calls on first `/api/models` / UI connection when dependencies were already installed during startup preinstall. - Reduces first-traffic latency and repeated `"Requirement already satisfied"` installation churn in logs. --- ### Additional Information - Motivation: in cold-start environments (e.g., new pods), startup already performs dependency preinstall, but first model/function load still triggered frontmatter installs per function, causing avoidable latency. - Behavior after fix: - Skip runtime frontmatter install when startup preinstall has completed and function content is unchanged and the function was included in startup preinstall. - Still install at runtime if: - startup preinstall has not completed, - function content changed, - function was not part of startup preinstall. ### Contributor License Agreement <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. Your PR will NOT be reviewed or merged until you check the box below confirming that you have read and agree to the terms of the CLA. --> - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 03:20:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#50559
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?