[PR #23631] [MERGED] fix: enforce model access control on Ollama generate, show, embed, embeddings endpoints #50337

New Issue

GiteaMirror · 2026-04-30T03:00:25-05:00

GiteaMirror commented

2026-04-30 03:00:25 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23631
Author: @Classic298
Created: 4/12/2026
Status: ✅ Merged
Merged: 4/12/2026
Merged by: @tjbck

Base: dev ← Head: fix/ollama-model-access-control

📝 Commits (1)

8d155d1 fix: enforce model access control on Ollama generate, show, embed, embeddings endpoints

📊 Changes

1 file changed (+15 additions, -2 deletions)

View changed files

📝 backend/open_webui/routers/ollama.py (+15 -2)

📄 Description

These four endpoints checked model existence but never verified the user has read access via AccessGrants, allowing any authenticated user to use restricted models.

Adds _verify_model_access helper mirroring the /api/chat access control pattern and applies it to /api/show, /api/embed, /api/embeddings, and /api/generate.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23631 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 4/12/2026 **Status:** ✅ Merged **Merged:** 4/12/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/ollama-model-access-control` --- ### 📝 Commits (1) - [`8d155d1`](https://github.com/open-webui/open-webui/commit/8d155d1bec2ddbb1ceb51351d668b533aa5526f3) fix: enforce model access control on Ollama generate, show, embed, embeddings endpoints ### 📊 Changes **1 file changed** (+15 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/ollama.py` (+15 -2) </details> ### 📄 Description These four endpoints checked model existence but never verified the user has read access via AccessGrants, allowing any authenticated user to use restricted models. Adds _verify_model_access helper mirroring the /api/chat access control pattern and applies it to /api/show, /api/embed, /api/embeddings, and /api/generate. ### Contributor License Agreement  - [X] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-30 03:00:25 -05:00

GiteaMirror closed this issue

2026-04-30 03:00:26 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#50337