[PR #23453] [MERGED] fix: use ipaddress stdlib for IPv6 SSRF protection #50250

Closed
opened 2026-04-30 02:52:52 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23453
Author: @Classic298
Created: 4/6/2026
Status: Merged
Merged: 4/12/2026
Merged by: @tjbck

Base: devHead: fix/ipv6-ssrf-protection-bypass


📝 Commits (1)

  • 7094edb fix: use ipaddress stdlib for IPv6 SSRF protection

📊 Changes

1 file changed (+4 additions, -5 deletions)

View changed files

📝 backend/open_webui/retrieval/web/utils.py (+4 -5)

📄 Description

The validators.ipv6(ip, private=True) call always returns a falsy ValidationError because validators==0.35.0 does not support the private kwarg for IPv6. This means any hostname resolving to a private IPv6 address (::1, fd00::*, ::ffff:169.254.169.254) bypasses SSRF protection entirely, circumventing the fix for CVE-2025-65958.

Replace both the IPv4 and IPv6 validators-based private checks with Python's stdlib ipaddress module, which correctly handles is_private, is_loopback, is_link_local, and is_reserved for both address families, including IPv4-mapped IPv6 addresses.

Contributor License Agreement

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23453 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 4/6/2026 **Status:** ✅ Merged **Merged:** 4/12/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/ipv6-ssrf-protection-bypass` --- ### 📝 Commits (1) - [`7094edb`](https://github.com/open-webui/open-webui/commit/7094edb54d0bff2755fa0bd7c659368e9fb318d7) fix: use ipaddress stdlib for IPv6 SSRF protection ### 📊 Changes **1 file changed** (+4 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/web/utils.py` (+4 -5) </details> ### 📄 Description The validators.ipv6(ip, private=True) call always returns a falsy ValidationError because validators==0.35.0 does not support the private kwarg for IPv6. This means any hostname resolving to a private IPv6 address (::1, fd00::*, ::ffff:169.254.169.254) bypasses SSRF protection entirely, circumventing the fix for CVE-2025-65958. Replace both the IPv4 and IPv6 validators-based private checks with Python's stdlib ipaddress module, which correctly handles is_private, is_loopback, is_link_local, and is_reserved for both address families, including IPv4-mapped IPv6 addresses. ### Contributor License Agreement <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. Your PR will NOT be reviewed or merged until you check the box below confirming that you have read and agree to the terms of the CLA. --> - [X] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 02:52:52 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#50250