[PR #23452] [CLOSED] fix: enforce default-deny access control in _validate_collection_access #50249

New Issue

GiteaMirror · 2026-04-30T02:52:48-05:00

GiteaMirror commented

2026-04-30 02:52:48 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23452
Author: @Classic298
Created: 4/6/2026
Status: ❌ Closed

Base: dev ← Head: fix/validate-collection-access-default-deny

📝 Commits (1)

9c71abb fix: enforce default-deny access control in _validate_collection_access

📊 Changes

2 files changed (+86 additions, -6 deletions)

View changed files

📝 backend/open_webui/models/knowledge.py (+11 -0)
📝 backend/open_webui/routers/retrieval.py (+75 -6)

📄 Description

Block non-admin users from querying the knowledge-bases system collection and arbitrary knowledge base document collections via the retrieval API.

The function previously only guarded user-memory-* and file-* prefixes, letting all other collection names (including the knowledge-bases metadata collection and per-KB UUID collections) pass through unchecked.

Now uses a default-deny approach:

user-memory-*: ownership check (unchanged)
file-*: file access check (unchanged)
web-search-*: allow (per-session, not sensitive)
knowledge-bases: block outright for non-admin users
anything else: look up as a knowledge base UUID and enforce ownership or AccessGrants read permission; deny if not found

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23452 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 4/6/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/validate-collection-access-default-deny` --- ### 📝 Commits (1) - [`9c71abb`](https://github.com/open-webui/open-webui/commit/9c71abbbfcd4e62cd5f996491b4f0439b5837638) fix: enforce default-deny access control in _validate_collection_access ### 📊 Changes **2 files changed** (+86 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/models/knowledge.py` (+11 -0) 📝 `backend/open_webui/routers/retrieval.py` (+75 -6) </details> ### 📄 Description Block non-admin users from querying the knowledge-bases system collection and arbitrary knowledge base document collections via the retrieval API. The function previously only guarded user-memory-* and file-* prefixes, letting all other collection names (including the knowledge-bases metadata collection and per-KB UUID collections) pass through unchecked. Now uses a default-deny approach: - user-memory-*: ownership check (unchanged) - file-*: file access check (unchanged) - web-search-*: allow (per-session, not sensitive) - knowledge-bases: block outright for non-admin users - anything else: look up as a knowledge base UUID and enforce ownership or AccessGrants read permission; deny if not found ### Contributor License Agreement  - [X] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-30 02:52:48 -05:00

GiteaMirror closed this issue

2026-04-30 02:52:50 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#50249