github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 10:58:17 -05:00
Code Issues 1.2k Packages Projects Releases 126 Wiki Activity

[PR #23302] [CLOSED] fix: improve OpenAI reasoning models support and fix reasoning_effort for Responses API #50186

New Issue
Closed
opened 2026-04-30 02:47:21 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 02:47:21 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23302
Author: @Kookiejarz
Created: 4/1/2026
Status: ❌ Closed

Base: dev ← Head: fix/openai-reasoning-effort

📝 Commits (10+)

📊 Changes

3 files changed (+18 additions, -6 deletions)

View changed files

📝 backend/open_webui/routers/openai.py (+15 -4)
📝 backend/open_webui/utils/payload.py (+1 -0)
📝 src/lib/components/chat/Settings/Advanced/AdvancedParams.svelte (+2 -2)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch. PRs targeting main will be immediately closed.
  • Description: Provide a concise description of the changes made in this pull request down below.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Add docs in Open WebUI Docs Repository. Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps.
  • Dependencies: Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash.
  • Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to make screenshots of the feature/fix and include them in the PR description.
  • Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Design & Architecture: Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes.
  • Git Hygiene: Keep PRs atomic (one logical change). Clean up commits and rebase on dev to ensure no unrelated commits (e.g. from main) are included. Push updates to the existing PR branch instead of closing and reopening.
  • Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • This PR improves support for OpenAI reasoning models (such as o1 and o3). It primarily resolves an issue where models were not correctly identified as reasoning models when using model names with prefixes (such as openai/o3-mini and azure/gpt-5). Additionally, it standardises the conversion of the reasoning_effort to reasoning.effort parameter format between the Chat Completions API and the Responses API.

Added

  • Added support for the reasoning.effort parameter format according to OpenAI's recent API changes for newer models.

Changed

  • The regular expression logic for is_openai_new_model has been updated to recognise inference models with provider prefixes.

  • The role mapping logic for inference models has been updated to ensure that prefixed o1-mini and o1-preview models
    are correctly downgraded to the user role, whilst other models use the developer role.

Deprecated

  • [List any deprecated functionality or features that have been removed]

Removed

  • [List any removed features, files, or functionalities]

Fixed

  • Fixed an issue where reasoning_effort in the OpenAI Responses API was not correctly nested within the {‘reasoning’: {“effort”: ‘...’}} object.
  • Fixed a bug where prefixed reasoning models were unable to automatically convert max_tokens to max_completion_tokens.
  • Prevents Unsupported parameter errors for non-reasoning models (like gpt-4) by automatically stripping reasoning-related parameters from the payload before sending.

Security

  • [List any new or updated security-related changes, including vulnerability fixes]

Breaking Changes

  • BREAKING CHANGE: [List any breaking changes affecting compatibility or functionality]

Additional Information

  • Manual testing and verification: The following scenarios have been verified using a dedicated test_logic.py script:
    • Models with prefixes such as openai/o3-mini are correctly identified.
    • max_tokens is correctly converted to max_completion_tokens.
    • The system role is correctly converted to developer or user depending on the model version.
    • Parameters under the Responses API are correctly nested.
    • Non-inference models such as gpt-4 are not affected.

Screenshots or Videos

Screenshot 2026-04-01 at 1 20 30 AM Screenshot 2026-04-01 at 1 16 05 AM Screenshot 2026-04-01 at 1 15 44 AM Screenshot 2026-04-01 at 1 33 32 AM

Contributor

License Agreement

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23302 **Author:** [@Kookiejarz](https://github.com/Kookiejarz) **Created:** 4/1/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/openai-reasoning-effort` --- ### 📝 Commits (10+) - [`fe6783c`](https://github.com/open-webui/open-webui/commit/fe6783c16699911c7be17392596d579333fb110c) Merge pull request #19030 from open-webui/dev - [`fc05e0a`](https://github.com/open-webui/open-webui/commit/fc05e0a6c5d39da60b603b4d520f800d6e36f748) Merge pull request #19405 from open-webui/dev - [`e3faec6`](https://github.com/open-webui/open-webui/commit/e3faec62c58e3a83d89aa3df539feacefa125e0c) Merge pull request #19416 from open-webui/dev - [`9899293`](https://github.com/open-webui/open-webui/commit/9899293f050ad50ae12024cbebee7e018acd851e) Merge pull request #19448 from open-webui/dev - [`140605e`](https://github.com/open-webui/open-webui/commit/140605e660b8186a7d5c79fb3be6ffb147a2f498) Merge pull request #19462 from open-webui/dev - [`6f1486f`](https://github.com/open-webui/open-webui/commit/6f1486ffd0cb288d0e21f41845361924e0d742b3) Merge pull request #19466 from open-webui/dev - [`d95f533`](https://github.com/open-webui/open-webui/commit/d95f533214e3fe5beb5e41ec1f349940bc4c7043) Merge pull request #19729 from open-webui/dev - [`a727153`](https://github.com/open-webui/open-webui/commit/a7271532f8a38da46785afcaa7e65f9a45e7d753) 0.6.43 (#20093) - [`6adde20`](https://github.com/open-webui/open-webui/commit/6adde203cd292a9e3af9c64a2ae36b603fed096a) Merge pull request #20394 from open-webui/dev - [`f9b0534`](https://github.com/open-webui/open-webui/commit/f9b0534e0c442631d1cb7205169588b9b6204179) Merge pull request #20522 from open-webui/dev ### 📊 Changes **3 files changed** (+18 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/openai.py` (+15 -4) 📝 `backend/open_webui/utils/payload.py` (+1 -0) 📝 `src/lib/components/chat/Settings/Advanced/AdvancedParams.svelte` (+2 -2) </details> ### 📄 Description <!-- ⚠️ CRITICAL CHECKS FOR CONTRIBUTORS (READ, DON'T DELETE) ⚠️ 1. Target the `dev` branch. PRs targeting `main` will be automatically closed. 2. Do NOT delete the CLA section at the bottom. It is required for the bot to accept your PR. --> # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **PRs targeting `main` will be immediately closed.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Add docs in [Open WebUI Docs Repository](https://github.com/open-webui/docs). Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps. - [x] **Dependencies:** Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash. - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to **make screenshots of the feature/fix and include them in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Design & Architecture:** Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes. - [x] **Git Hygiene:** Keep PRs atomic (one logical change). Clean up commits and rebase on `dev` to ensure no unrelated commits (e.g. from `main`) are included. Push updates to the existing PR branch instead of closing and reopening. - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - This PR improves support for OpenAI reasoning models (such as o1 and o3). It primarily resolves an issue where models were not correctly identified as reasoning models when using model names with prefixes (such as openai/o3-mini and azure/gpt-5). Additionally, it standardises the conversion of the `reasoning_effort` to `reasoning.effort` parameter format between the Chat Completions API and the Responses API. ### Added - Added support for the `reasoning.effort` parameter format according to OpenAI's recent API changes for newer models. ### Changed - The regular expression logic for `is_openai_new_model` has been updated to recognise inference models with provider prefixes. - The role mapping logic for inference models has been updated to ensure that prefixed `o1-mini` and `o1-preview` models are correctly downgraded to the `user` role, whilst other models use the `developer` role. ### Deprecated - [List any deprecated functionality or features that have been removed] ### Removed - [List any removed features, files, or functionalities] ### Fixed - Fixed an issue where `reasoning_effort` in the OpenAI Responses API was not correctly nested within the {‘reasoning’: {“effort”: ‘...’}} object. - Fixed a bug where prefixed reasoning models were unable to automatically convert `max_tokens` to `max_completion_tokens`. - Prevents Unsupported parameter errors for non-reasoning models (like gpt-4) by automatically stripping reasoning-related parameters from the payload before sending. ### Security - [List any new or updated security-related changes, including vulnerability fixes] ### Breaking Changes - **BREAKING CHANGE**: [List any breaking changes affecting compatibility or functionality] --- ### Additional Information - Manual testing and verification: The following scenarios have been verified using a dedicated test_logic.py script: - [x] Models with prefixes such as openai/o3-mini are correctly identified. - [x] `max_tokens` is correctly converted to `max_completion_tokens`. - [x] The `system` role is correctly converted to `developer` or `user` depending on the model version. - [x] Parameters under the Responses API are correctly nested. - [x] Non-inference models such as `gpt-4` are not affected. ### Screenshots or Videos <img width="1280" height="661" alt="Screenshot 2026-04-01 at 1 20 30 AM" src="https://github.com/user-attachments/assets/350636f3-4f1d-414f-9d29-8c05c5f53af5" /> <img width="1280" height="659" alt="Screenshot 2026-04-01 at 1 16 05 AM" src="https://github.com/user-attachments/assets/9e1e24c2-a4ea-43e3-b2e3-637e2d7ba40a" /> <img width="1277" height="659" alt="Screenshot 2026-04-01 at 1 15 44 AM" src="https://github.com/user-attachments/assets/7a844ac8-f4bf-4568-a56c-c9e85b31f3fb" /> <img width="1058" height="506" alt="Screenshot 2026-04-01 at 1 33 32 AM" src="https://github.com/user-attachments/assets/bbde524e-0b9d-470b-a071-5a014535a2d5" /> ### Contributor License Agreement <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. Your PR will NOT be reviewed or merged until you check the box below confirming that you have read and agree to the terms of the CLA. --> - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 02:47:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#50186
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?