[PR #22829] [CLOSED] fix: prevent event bubbling on memory delete/edit buttons #49928

New Issue

GiteaMirror · 2026-04-30T02:22:17-05:00

GiteaMirror commented

2026-04-30 02:22:17 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/22829
Author: @xr843
Created: 3/19/2026
Status: ❌ Closed

Base: dev ← Head: fix/22783-memory-delete-event-bubbling

📝 Commits (1)

f99531a fix: prevent event bubbling on memory delete/edit buttons (#22783)

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/lib/components/chat/Settings/Personalization/ManageModal.svelte (+2 -2)

📄 Description

Summary

Fixes #22783: Clicking the Delete (trash) button in the Memory management modal triggers event bubbling, causing the parent click handler to open the Edit modal for the already-deleted memory.
Added |stopPropagation modifier to both the Edit and Delete button on:click handlers in ManageModal.svelte to prevent the click event from propagating to parent elements.

Test plan

Open Settings > Personalization > Manage (Memory)
Click the Delete (trash) icon on a memory entry
Verify the memory is deleted and the Edit modal does NOT open
Click the Edit (pencil) icon on a memory entry
Verify only the Edit modal opens without any duplicate event issues

Closes #22783

CLA Confirmation

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license and I agree to the Open WebUI Contributor License Agreement.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/22829 **Author:** [@xr843](https://github.com/xr843) **Created:** 3/19/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/22783-memory-delete-event-bubbling` --- ### 📝 Commits (1) - [`f99531a`](https://github.com/open-webui/open-webui/commit/f99531a200b2b621311005f0991b05147117a2b3) fix: prevent event bubbling on memory delete/edit buttons (#22783) ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Settings/Personalization/ManageModal.svelte` (+2 -2) </details> ### 📄 Description ## Summary - Fixes #22783: Clicking the Delete (trash) button in the Memory management modal triggers event bubbling, causing the parent click handler to open the Edit modal for the already-deleted memory. - Added `|stopPropagation` modifier to both the Edit and Delete button `on:click` handlers in `ManageModal.svelte` to prevent the click event from propagating to parent elements. ## Test plan - [ ] Open Settings > Personalization > Manage (Memory) - [ ] Click the Delete (trash) icon on a memory entry - [ ] Verify the memory is deleted and the Edit modal does NOT open - [ ] Click the Edit (pencil) icon on a memory entry - [ ] Verify only the Edit modal opens without any duplicate event issues Closes #22783 --- ### CLA Confirmation By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license and I agree to the Open WebUI Contributor License Agreement. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-30 02:22:17 -05:00

GiteaMirror closed this issue

2026-04-30 02:22:21 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#49928