github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 10:58:17 -05:00
Code Issues 1.2k Packages Projects Releases 126 Wiki Activity

[PR #22761] [CLOSED] fix: Fix streaming JSON parsing and preserve model tool_ids #49898

New Issue
Closed
opened 2026-04-30 02:19:01 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 02:19:01 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/22761
Author: @teenccu
Created: 3/17/2026
Status: ❌ Closed

Base: dev ← Head: fix/openwebui-streaming-toolids

📝 Commits (10+)

📊 Changes

2 files changed (+70 additions, -5112 deletions)

View changed files

📝 backend/open_webui/utils/middleware.py (+17 -4870)
📝 backend/open_webui/utils/response.py (+53 -242)

📄 Description

Title: Fix streaming JSON parsing and preserve model tool_ids

Description:

  • Add robust newline-buffered JSON parsing for Open WebUI streaming responses
    to avoid partial-chunk JSON decode errors when processing SSE/text streams.
  • Preserve configured tool_ids from model presets when requests omit them,
    preventing accidental removal of available tools.

Files added:

  • backend/open_webui/utils/response.py (stream parsing helpers)
  • backend/open_webui/utils/middleware.py (tool_ids preservation helper)

How to test locally:

  1. Clone this branch into your fork of open-webui (based off v0.8.10).
  2. Replace the two files under backend/open_webui/utils/ with the ones in
    this patch.
  3. Restart Open WebUI and verify streaming scenarios (e.g. Ollama / model
    streaming) work without JSON decode errors and that model presets retain
    their configured tool_ids when issuing chat requests without tool_ids.

Suggested PR body:
This patch fixes two related runtime issues observed in environments where
model/tool responses are streamed via SSE or where model presets include a
list of tool_ids.

  1. response.py ensures partial text chunks are buffered and JSON objects
    are only parsed once a full newline-delimited message is available. This
    removes intermittent JSON decoding errors and prevents loss of streamed
    tool_call messages.

  2. middleware.py preserves model preset tool_ids when a request does not
    explicitly provide tool_ids, ensuring the model retains access to tools
    previously configured in Open WebUI.

Both changes are small and low-risk; they improve stability of tool-calling
flows and streaming responses.

I confirm: I have read and agree to the Contributor License Agreement (CLA).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/22761 **Author:** [@teenccu](https://github.com/teenccu) **Created:** 3/17/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/openwebui-streaming-toolids` --- ### 📝 Commits (10+) - [`fe6783c`](https://github.com/open-webui/open-webui/commit/fe6783c16699911c7be17392596d579333fb110c) Merge pull request #19030 from open-webui/dev - [`fc05e0a`](https://github.com/open-webui/open-webui/commit/fc05e0a6c5d39da60b603b4d520f800d6e36f748) Merge pull request #19405 from open-webui/dev - [`e3faec6`](https://github.com/open-webui/open-webui/commit/e3faec62c58e3a83d89aa3df539feacefa125e0c) Merge pull request #19416 from open-webui/dev - [`9899293`](https://github.com/open-webui/open-webui/commit/9899293f050ad50ae12024cbebee7e018acd851e) Merge pull request #19448 from open-webui/dev - [`140605e`](https://github.com/open-webui/open-webui/commit/140605e660b8186a7d5c79fb3be6ffb147a2f498) Merge pull request #19462 from open-webui/dev - [`6f1486f`](https://github.com/open-webui/open-webui/commit/6f1486ffd0cb288d0e21f41845361924e0d742b3) Merge pull request #19466 from open-webui/dev - [`d95f533`](https://github.com/open-webui/open-webui/commit/d95f533214e3fe5beb5e41ec1f349940bc4c7043) Merge pull request #19729 from open-webui/dev - [`a727153`](https://github.com/open-webui/open-webui/commit/a7271532f8a38da46785afcaa7e65f9a45e7d753) 0.6.43 (#20093) - [`6adde20`](https://github.com/open-webui/open-webui/commit/6adde203cd292a9e3af9c64a2ae36b603fed096a) Merge pull request #20394 from open-webui/dev - [`f9b0534`](https://github.com/open-webui/open-webui/commit/f9b0534e0c442631d1cb7205169588b9b6204179) Merge pull request #20522 from open-webui/dev ### 📊 Changes **2 files changed** (+70 additions, -5112 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/middleware.py` (+17 -4870) 📝 `backend/open_webui/utils/response.py` (+53 -242) </details> ### 📄 Description Title: Fix streaming JSON parsing and preserve model tool_ids Description: - Add robust newline-buffered JSON parsing for Open WebUI streaming responses to avoid partial-chunk JSON decode errors when processing SSE/text streams. - Preserve configured `tool_ids` from model presets when requests omit them, preventing accidental removal of available tools. Files added: - backend/open_webui/utils/response.py (stream parsing helpers) - backend/open_webui/utils/middleware.py (tool_ids preservation helper) How to test locally: 1. Clone this branch into your fork of open-webui (based off v0.8.10). 2. Replace the two files under `backend/open_webui/utils/` with the ones in this patch. 3. Restart Open WebUI and verify streaming scenarios (e.g. Ollama / model streaming) work without JSON decode errors and that model presets retain their configured `tool_ids` when issuing chat requests without `tool_ids`. Suggested PR body: This patch fixes two related runtime issues observed in environments where model/tool responses are streamed via SSE or where model presets include a list of `tool_ids`. 1) `response.py` ensures partial text chunks are buffered and JSON objects are only parsed once a full newline-delimited message is available. This removes intermittent JSON decoding errors and prevents loss of streamed tool_call messages. 2) `middleware.py` preserves model preset `tool_ids` when a request does not explicitly provide `tool_ids`, ensuring the model retains access to tools previously configured in Open WebUI. Both changes are small and low-risk; they improve stability of tool-calling flows and streaming responses. I confirm: I have read and agree to the Contributor License Agreement (CLA). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 02:19:01 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#49898
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?