[PR #22703] [CLOSED] fix: add missing has_public_read_access_grant import in notes.py #49870

New Issue

GiteaMirror · 2026-04-30T02:16:01-05:00

GiteaMirror commented

2026-04-30 02:16:01 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/22703
Author: @mvanhorn
Created: 3/15/2026
Status: ❌ Closed

Base: dev ← Head: osc/22680-notes-missing-import-v2

📝 Commits (1)

9e51cd5 fix: add missing has_public_read_access_grant import in notes.py

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 backend/open_webui/routers/notes.py (+1 -1)

📄 Description

Summary

Adds the missing has_public_read_access_grant import to notes.py. The function is called at line 239 but was never imported, causing a NameError at runtime when notes with public read access grants are accessed.

Changes

Added has_public_read_access_grant to the existing import from open_webui.models.access_grants on line 31, matching the pattern used in channels.py:39.

Testing

Verified the function exists in models/access_grants.py:193
Verified channels.py uses the same import pattern successfully

Fixes #22680

This contribution was developed with AI assistance (Claude Code).

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/22703 **Author:** [@mvanhorn](https://github.com/mvanhorn) **Created:** 3/15/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `osc/22680-notes-missing-import-v2` --- ### 📝 Commits (1) - [`9e51cd5`](https://github.com/open-webui/open-webui/commit/9e51cd504be625902f3b833027901d9d9be9f6e6) fix: add missing has_public_read_access_grant import in notes.py ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/notes.py` (+1 -1) </details> ### 📄 Description ## Summary Adds the missing `has_public_read_access_grant` import to `notes.py`. The function is called at line 239 but was never imported, causing a `NameError` at runtime when notes with public read access grants are accessed. ## Changes Added `has_public_read_access_grant` to the existing import from `open_webui.models.access_grants` on line 31, matching the pattern used in `channels.py:39`. ## Testing - Verified the function exists in `models/access_grants.py:193` - Verified `channels.py` uses the same import pattern successfully Fixes #22680 This contribution was developed with AI assistance (Claude Code). ### Contributor License Agreement - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-30 02:16:01 -05:00

GiteaMirror closed this issue

2026-04-30 02:16:08 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#49870