[PR #21882] [CLOSED] perf: remove unnecessary {#key id} block in Markdown.svelte #49367

New Issue

GiteaMirror · 2026-04-30T01:40:35-05:00

GiteaMirror commented

2026-04-30 01:40:35 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/21882
Author: @Classic298
Created: 2/25/2026
Status: ❌ Closed

Base: dev ← Head: perf/remove-markdown-key

📝 Commits (1)

0ef287d perf: remove unnecessary {#key id} block in Markdown.svelte

📊 Changes

1 file changed (+17 additions, -18 deletions)

View changed files

📝 src/lib/components/chat/Messages/Markdown.svelte (+17 -18)

📄 Description

The {#key id} wrapper around MarkdownTokens forced Svelte to destroy and recreate the entire token component tree whenever id changed. Since id is derived from chatId + messageId and is stable during streaming, this mainly prevented Svelte from reusing components across re-renders and forced all child components like KatexRenderer and CodeBlock to remount. The tokens prop already drives reactivity, making the key block redundant.

this is a completely invisible change - free lunch

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/21882 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 2/25/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `perf/remove-markdown-key` --- ### 📝 Commits (1) - [`0ef287d`](https://github.com/open-webui/open-webui/commit/0ef287d2a713a2ea0be0120025420c6668806f60) perf: remove unnecessary {#key id} block in Markdown.svelte ### 📊 Changes **1 file changed** (+17 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Messages/Markdown.svelte` (+17 -18) </details> ### 📄 Description The {#key id} wrapper around MarkdownTokens forced Svelte to destroy and recreate the entire token component tree whenever id changed. Since id is derived from chatId + messageId and is stable during streaming, this mainly prevented Svelte from reusing components across re-renders and forced all child components like KatexRenderer and CodeBlock to remount. The tokens prop already drives reactivity, making the key block redundant. <ins>**this is a completely invisible change - free lunch**</ins> ### Contributor License Agreement  By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-30 01:40:35 -05:00

GiteaMirror closed this issue

2026-04-30 01:40:39 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#49367