github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-08 21:09:41 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #21856] [CLOSED] fix: sharing modal not showing users when access_grants missing from stored config #49356

New Issue
Closed
opened 2026-04-30 01:39:50 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 01:39:50 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/21856
Author: @Classic298
Created: 2/25/2026
Status: ❌ Closed

Base: dev ← Head: claude/fix-sharing-modal-bug-48k67

📝 Commits (2)

  • 6c61024 fix: sharing modal not showing users when access_grants missing from stored config
  • 9555c6b fix: include access_grants in frontend permission merge functions

📊 Changes

3 files changed (+7 additions, -0 deletions)

View changed files

📝 backend/open_webui/utils/access_control.py (+5 -0)
📝 src/lib/components/admin/Users/Groups/EditGroupModal.svelte (+1 -0)
📝 src/lib/components/admin/Users/Groups/Permissions.svelte (+1 -0)

📄 Description

Summary

  • Fix sharing modal not showing user-to-user sharing options for non-admin users after the access_grants permission feature was introduced
  • Root cause: the new access_grants permission section was missing from three places that enumerate permission keys — backend get_permissions() fallback, EditGroupModal.init() merge, and Permissions.svelte fillMissingProperties()
  • When USER_PERMISSIONS was saved to the DB before access_grants existed, the stored config lacked the key, causing $user.permissions.access_grants to be undefined and shareUsers to evaluate to false

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/21856 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 2/25/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `claude/fix-sharing-modal-bug-48k67` --- ### 📝 Commits (2) - [`6c61024`](https://github.com/open-webui/open-webui/commit/6c61024b78107258386bc03006798b2337971a33) fix: sharing modal not showing users when access_grants missing from stored config - [`9555c6b`](https://github.com/open-webui/open-webui/commit/9555c6b8753b6f6df17675f17011f8a0ff46d850) fix: include access_grants in frontend permission merge functions ### 📊 Changes **3 files changed** (+7 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/access_control.py` (+5 -0) 📝 `src/lib/components/admin/Users/Groups/EditGroupModal.svelte` (+1 -0) 📝 `src/lib/components/admin/Users/Groups/Permissions.svelte` (+1 -0) </details> ### 📄 Description ## Summary - Fix sharing modal not showing user-to-user sharing options for non-admin users after the `access_grants` permission feature was introduced - Root cause: the new `access_grants` permission section was missing from three places that enumerate permission keys — backend `get_permissions()` fallback, `EditGroupModal.init()` merge, and `Permissions.svelte` `fillMissingProperties()` - When `USER_PERMISSIONS` was saved to the DB before `access_grants` existed, the stored config lacked the key, causing `$user.permissions.access_grants` to be `undefined` and `shareUsers` to evaluate to `false` ### Contributor License Agreement <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. --> By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 01:39:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#49356
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?