github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 10:58:17 -05:00
Code Issues 1.2k Packages Projects Releases 126 Wiki Activity

[PR #21370] [CLOSED] fix: Pass configured tools to models in multi-model comparison mode #49099

New Issue
Closed
opened 2026-04-30 01:24:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 01:24:43 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/21370
Author: @YannickPezeu
Created: 2/13/2026
Status: ❌ Closed

Base: dev ← Head: multi_model_tools

📝 Commits (10+)

📊 Changes

6 files changed (+42 additions, -2 deletions)

View changed files

📝 backend/open_webui/config.py (+6 -0)
📝 backend/open_webui/main.py (+3 -0)
📝 backend/open_webui/routers/auths.py (+4 -0)
📝 src/lib/components/admin/Settings/General.svelte (+13 -0)
📝 src/lib/components/chat/Chat.svelte (+7 -1)
📝 src/lib/components/chat/Messages/Citations/CitationModal.svelte (+9 -1)

📄 Description

Pull Request Checklist

  • Target branch: Targets the dev branch.
  • Description: See below.
  • Testing: Manually tested locally and on staging deployment.
  • Code review: Self-reviewed.

Changelog Entry

Description

Fixes a bug where tools configured on custom models were not loaded when using side-by-side multi-model comparison. Each model now correctly receives its configured tools merged with any user-selected tools.

Fixed

  • In Chat.svelte, setDefaults() returns early when multiple models are selected, which skipped tool loading entirely
  • sendMessageSocket() used the global selectedToolIds which was empty in multi-model mode
  • Now merges model-configured tools (model.info.meta.toolIds) with user-selected tools per-model in sendMessageSocket()

Additional Information

  • Root cause: setDefaults() at line 275 has an early return for multi-model mode, preventing selectedToolIds from being populated
  • Fix ensures each model gets its own correct set of tools without breaking single-model mode

Screenshots or Videos

  • Tested locally and on Kubernetes staging deployment at EPFL with multiple models side-by-side, each with different tools assigned

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/21370 **Author:** [@YannickPezeu](https://github.com/YannickPezeu) **Created:** 2/13/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `multi_model_tools` --- ### 📝 Commits (10+) - [`fe6783c`](https://github.com/open-webui/open-webui/commit/fe6783c16699911c7be17392596d579333fb110c) Merge pull request #19030 from open-webui/dev - [`fc05e0a`](https://github.com/open-webui/open-webui/commit/fc05e0a6c5d39da60b603b4d520f800d6e36f748) Merge pull request #19405 from open-webui/dev - [`e3faec6`](https://github.com/open-webui/open-webui/commit/e3faec62c58e3a83d89aa3df539feacefa125e0c) Merge pull request #19416 from open-webui/dev - [`9899293`](https://github.com/open-webui/open-webui/commit/9899293f050ad50ae12024cbebee7e018acd851e) Merge pull request #19448 from open-webui/dev - [`140605e`](https://github.com/open-webui/open-webui/commit/140605e660b8186a7d5c79fb3be6ffb147a2f498) Merge pull request #19462 from open-webui/dev - [`6f1486f`](https://github.com/open-webui/open-webui/commit/6f1486ffd0cb288d0e21f41845361924e0d742b3) Merge pull request #19466 from open-webui/dev - [`d95f533`](https://github.com/open-webui/open-webui/commit/d95f533214e3fe5beb5e41ec1f349940bc4c7043) Merge pull request #19729 from open-webui/dev - [`a727153`](https://github.com/open-webui/open-webui/commit/a7271532f8a38da46785afcaa7e65f9a45e7d753) 0.6.43 (#20093) - [`6adde20`](https://github.com/open-webui/open-webui/commit/6adde203cd292a9e3af9c64a2ae36b603fed096a) Merge pull request #20394 from open-webui/dev - [`f9b0534`](https://github.com/open-webui/open-webui/commit/f9b0534e0c442631d1cb7205169588b9b6204179) Merge pull request #20522 from open-webui/dev ### 📊 Changes **6 files changed** (+42 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/config.py` (+6 -0) 📝 `backend/open_webui/main.py` (+3 -0) 📝 `backend/open_webui/routers/auths.py` (+4 -0) 📝 `src/lib/components/admin/Settings/General.svelte` (+13 -0) 📝 `src/lib/components/chat/Chat.svelte` (+7 -1) 📝 `src/lib/components/chat/Messages/Citations/CitationModal.svelte` (+9 -1) </details> ### 📄 Description # Pull Request Checklist - [x] **Target branch:** Targets the `dev` branch. - [x] **Description:** See below. - [x] **Testing:** Manually tested locally and on staging deployment. - [x] **Code review:** Self-reviewed. # Changelog Entry ### Description Fixes a bug where tools configured on custom models were not loaded when using side-by-side multi-model comparison. Each model now correctly receives its configured tools merged with any user-selected tools. ### Fixed - In `Chat.svelte`, `setDefaults()` returns early when multiple models are selected, which skipped tool loading entirely - `sendMessageSocket()` used the global `selectedToolIds` which was empty in multi-model mode - Now merges model-configured tools (`model.info.meta.toolIds`) with user-selected tools per-model in `sendMessageSocket()` ### Additional Information - Root cause: `setDefaults()` at line 275 has an early return for multi-model mode, preventing `selectedToolIds` from being populated - Fix ensures each model gets its own correct set of tools without breaking single-model mode ### Screenshots or Videos - Tested locally and on Kubernetes staging deployment at EPFL with multiple models side-by-side, each with different tools assigned --- ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 01:24:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#49099
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?