[PR #21013] [MERGED] perf: eliminate redundant query after memory update #48935

New Issue

GiteaMirror · 2026-04-30T01:10:00-05:00

GiteaMirror commented

2026-04-30 01:10:00 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/21013
Author: @Classic298
Created: 1/28/2026
Status: ✅ Merged
Merged: 1/29/2026
Merged by: @tjbck

Base: dev ← Head: memory

📝 Commits (1)

92a7fdd perf: eliminate redundant query after memory update

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 backend/open_webui/models/memories.py (+2 -1)

📄 Description

Summary

Eliminates redundant database query in update_memory_by_id_and_user_id. Previously, after modifying the memory object, it called get_memory_by_id which opened a new session and queried again.

Changes

models/memories.py update_memory_by_id_and_user_id:

Replace self.get_memory_by_id(id) with db.refresh(memory)
Return the same memory object that was already modified

Performance Impact

Before: 2 queries (get + get_memory_by_id)
After: 1 query + refresh on same session

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/21013 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 1/28/2026 **Status:** ✅ Merged **Merged:** 1/29/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `memory` --- ### 📝 Commits (1) - [`92a7fdd`](https://github.com/open-webui/open-webui/commit/92a7fdddd4010370057d396d807c0246692ff09d) perf: eliminate redundant query after memory update ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/models/memories.py` (+2 -1) </details> ### 📄 Description ## Summary Eliminates redundant database query in update_memory_by_id_and_user_id. Previously, after modifying the memory object, it called get_memory_by_id which opened a new session and queried again. ## Changes models/memories.py update_memory_by_id_and_user_id: - Replace self.get_memory_by_id(id) with db.refresh(memory) - Return the same memory object that was already modified ## Performance Impact Before: 2 queries (get + get_memory_by_id) After: 1 query + refresh on same session ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-30 01:10:00 -05:00

GiteaMirror closed this issue

2026-04-30 01:10:03 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#48935