[PR #20581] [MERGED] fix(db): release connection before embedding in memory /{memory_id}/update #48734

New Issue

GiteaMirror · 2026-04-30T00:46:46-05:00

GiteaMirror commented

2026-04-30 00:46:46 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/20581
Author: @Classic298
Created: 1/11/2026
Status: ✅ Merged
Merged: 1/11/2026
Merged by: @tjbck

Base: dev ← Head: fix/db-pool-memory-update

📝 Commits (1)

01b2c7f fix(db): release connection before embedding in memory /{memory_id}/update

📊 Changes

1 file changed (+5 additions, -2 deletions)

View changed files

📝 backend/open_webui/routers/memories.py (+5 -2)

📄 Description

Remove Depends(get_session) from POST /{memory_id}/update endpoint to prevent database connections from being held during embedding API calls (1-5+ seconds).

The Memories.update_memory_by_id_and_user_id() function manages its own short-lived session internally, releasing the connection before the slow EMBEDDING_FUNCTION() call begins.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/20581 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 1/11/2026 **Status:** ✅ Merged **Merged:** 1/11/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/db-pool-memory-update` --- ### 📝 Commits (1) - [`01b2c7f`](https://github.com/open-webui/open-webui/commit/01b2c7fe8e1135f0ad59310d01c2671afce2880a) fix(db): release connection before embedding in memory /{memory_id}/update ### 📊 Changes **1 file changed** (+5 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/memories.py` (+5 -2) </details> ### 📄 Description Remove Depends(get_session) from POST /{memory_id}/update endpoint to prevent database connections from being held during embedding API calls (1-5+ seconds). The Memories.update_memory_by_id_and_user_id() function manages its own short-lived session internally, releasing the connection before the slow EMBEDDING_FUNCTION() call begins. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-30 00:46:47 -05:00

GiteaMirror closed this issue

2026-04-30 00:46:48 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#48734