github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 10:58:17 -05:00
Code Issues 1.2k Packages Projects Releases 126 Wiki Activity

[PR #19956] [CLOSED] feat: group managers - allow specified non-admins to add/remove users from groups. #48458

New Issue
Closed
opened 2026-04-30 00:21:31 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 00:21:31 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/19956
Author: @daw
Created: 12/14/2025
Status: ❌ Closed

Base: dev ← Head: feature/group-managers

📝 Commits (10+)

📊 Changes

17 files changed (+1070 additions, -983 deletions)

View changed files

➕ backend/open_webui/migrations/versions/add_group_member_role.py (+31 -0)
📝 backend/open_webui/models/groups.py (+106 -0)
📝 backend/open_webui/routers/groups.py (+148 -26)
📝 backend/open_webui/routers/prompts.py (+7 -2)
📝 backend/open_webui/routers/users.py (+10 -1)
📝 package-lock.json (+110 -547)
📝 package.json (+1 -0)
📝 src/lib/apis/groups/index.ts (+96 -0)
📝 src/lib/components/admin/Users.svelte (+97 -70)
📝 src/lib/components/admin/Users/Groups.svelte (+100 -72)
📝 src/lib/components/admin/Users/Groups/EditGroupModal.svelte (+56 -54)
📝 src/lib/components/admin/Users/Groups/General.svelte (+27 -44)
📝 src/lib/components/admin/Users/Groups/GroupItem.svelte (+6 -0)
➕ src/lib/components/admin/Users/Groups/Managers.svelte (+164 -0)
📝 src/lib/components/admin/Users/Groups/Users.svelte (+2 -1)
📝 src/lib/components/layout/Sidebar/UserMenu.svelte (+35 -139)
📝 src/routes/(app)/admin/+layout.svelte (+74 -27)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
  • Description: Provide a concise description of the changes made in this pull request down below.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
  • Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This PR implements Group Managers functionality, allowing non-admin users to be designated as managers of specific groups with limited administrative capabilities. It does not attempt to introduce a broader roles and permissions system, it is a targeted change that gives the assigned users the ability to add and remove users from the groups they manage.

What Group Managers CAN Do:

  • View groups they manage - see the groups where they've been assigned as a manager
  • Add users to their groups - add new members to groups they manage
  • Remove regular members from their groups - remove users (but not other managers)
  • View group membership - see who is in the groups they manage

What Group Managers CANNOT Do:

  • Create new groups - only admins can create groups
  • Delete groups - only admins
  • Modify group settings (name, description, permissions) - only admins
  • Add/remove managers - only admins can assign or remove group managers
  • Remove other managers from a group - protected to prevent managers from locking each other out
  • Access other admin pages (Users Overview, Evaluations, Functions, Settings) - they're redirected to /admin/users/groups if they try
  • Manage groups they don't manage - they only see and can modify their assigned groups

Added

Backend:

  • Added role column to group_member table (member or manager)
  • New endpoints: GET /api/v1/groups/user/managed, POST /api/v1/groups/{id}/managers
  • Authorization checks to ensure managers can only modify groups they manage
  • Managers cannot remove other managers from groups

Frontend:

  • New Managers.svelte component for manager selection with optimistic updates and rollback
  • Updated admin layout to allow group manager access to groups page
  • Updated Users.svelte to filter out managers from the user list

Database Migration:

  • Added new migration for group_member.role column

Changed

Deprecated

Removed

Fixed

Security

  • [List any new or updated security-related changes, including vulnerability fixes]

Breaking Changes

  • BREAKING CHANGE: [List any breaking changes affecting compatibility or functionality]

Additional Information

  • [Insert any additional context, notes, or explanations for the changes]
    • [Reference any related issues, commits, or other relevant information]

Screenshots or Videos

Screenshot 2025-12-14 at 4 41 42 PM Screenshot 2025-12-14 at 1 55 23 PM

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/19956 **Author:** [@daw](https://github.com/daw) **Created:** 12/14/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `feature/group-managers` --- ### 📝 Commits (10+) - [`fe6783c`](https://github.com/open-webui/open-webui/commit/fe6783c16699911c7be17392596d579333fb110c) Merge pull request #19030 from open-webui/dev - [`fc05e0a`](https://github.com/open-webui/open-webui/commit/fc05e0a6c5d39da60b603b4d520f800d6e36f748) Merge pull request #19405 from open-webui/dev - [`e3faec6`](https://github.com/open-webui/open-webui/commit/e3faec62c58e3a83d89aa3df539feacefa125e0c) Merge pull request #19416 from open-webui/dev - [`9899293`](https://github.com/open-webui/open-webui/commit/9899293f050ad50ae12024cbebee7e018acd851e) Merge pull request #19448 from open-webui/dev - [`140605e`](https://github.com/open-webui/open-webui/commit/140605e660b8186a7d5c79fb3be6ffb147a2f498) Merge pull request #19462 from open-webui/dev - [`f83d2ff`](https://github.com/open-webui/open-webui/commit/f83d2ffdd7a653377b802c77d0d3c28e0b9727bb) feat: Add group managers feature - [`07bee79`](https://github.com/open-webui/open-webui/commit/07bee79788972e0f1601fd3f287b4bd678d55bda) fix: Group managers UX improvements - [`6f1486f`](https://github.com/open-webui/open-webui/commit/6f1486ffd0cb288d0e21f41845361924e0d742b3) Merge pull request #19466 from open-webui/dev - [`f759fa0`](https://github.com/open-webui/open-webui/commit/f759fa07bccdfdc6625ef5cfee16723bb92f2de9) Update backend/open_webui/routers/groups.py - [`909c957`](https://github.com/open-webui/open-webui/commit/909c9571a8fe5c78c023467dd89693e9dc973e4f) Update src/lib/apis/prompts/index.ts ### 📊 Changes **17 files changed** (+1070 additions, -983 deletions) <details> <summary>View changed files</summary> ➕ `backend/open_webui/migrations/versions/add_group_member_role.py` (+31 -0) 📝 `backend/open_webui/models/groups.py` (+106 -0) 📝 `backend/open_webui/routers/groups.py` (+148 -26) 📝 `backend/open_webui/routers/prompts.py` (+7 -2) 📝 `backend/open_webui/routers/users.py` (+10 -1) 📝 `package-lock.json` (+110 -547) 📝 `package.json` (+1 -0) 📝 `src/lib/apis/groups/index.ts` (+96 -0) 📝 `src/lib/components/admin/Users.svelte` (+97 -70) 📝 `src/lib/components/admin/Users/Groups.svelte` (+100 -72) 📝 `src/lib/components/admin/Users/Groups/EditGroupModal.svelte` (+56 -54) 📝 `src/lib/components/admin/Users/Groups/General.svelte` (+27 -44) 📝 `src/lib/components/admin/Users/Groups/GroupItem.svelte` (+6 -0) ➕ `src/lib/components/admin/Users/Groups/Managers.svelte` (+164 -0) 📝 `src/lib/components/admin/Users/Groups/Users.svelte` (+2 -1) 📝 `src/lib/components/layout/Sidebar/UserMenu.svelte` (+35 -139) 📝 `src/routes/(app)/admin/+layout.svelte` (+74 -27) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **Not targeting the `dev` branch will lead to immediate closure of the PR.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Take this as an opportunity to **make screenshots of the feature/fix and include it in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description This PR implements Group Managers functionality, allowing non-admin users to be designated as managers of specific groups with limited administrative capabilities. It does not attempt to introduce a broader roles and permissions system, it is a targeted change that gives the assigned users the ability to add and remove users from the groups they manage. What Group Managers CAN Do: - View groups they manage - see the groups where they've been assigned as a manager - Add users to their groups - add new members to groups they manage - Remove regular members from their groups - remove users (but not other managers) - View group membership - see who is in the groups they manage What Group Managers CANNOT Do: - Create new groups - only admins can create groups - Delete groups - only admins - Modify group settings (name, description, permissions) - only admins - Add/remove managers - only admins can assign or remove group managers - Remove other managers from a group - protected to prevent managers from locking each other out - Access other admin pages (Users Overview, Evaluations, Functions, Settings) - they're redirected to /admin/users/groups if they try - Manage groups they don't manage - they only see and can modify their assigned groups ### Added Backend: - Added role column to group_member table (member or manager) - New endpoints: GET /api/v1/groups/user/managed, POST /api/v1/groups/{id}/managers - Authorization checks to ensure managers can only modify groups they manage - Managers cannot remove other managers from groups Frontend: - New Managers.svelte component for manager selection with optimistic updates and rollback - Updated admin layout to allow group manager access to groups page - Updated Users.svelte to filter out managers from the user list Database Migration: - Added new migration for group_member.role column ### Changed ### Deprecated ### Removed ### Fixed ### Security - [List any new or updated security-related changes, including vulnerability fixes] ### Breaking Changes - **BREAKING CHANGE**: [List any breaking changes affecting compatibility or functionality] --- ### Additional Information - [Insert any additional context, notes, or explanations for the changes] - [Reference any related issues, commits, or other relevant information] ### Screenshots or Videos <img width="1858" height="1197" alt="Screenshot 2025-12-14 at 4 41 42 PM" src="https://github.com/user-attachments/assets/4f6bf5f7-f3a8-474d-9dd0-c5d01202c657" /> <img width="1173" height="867" alt="Screenshot 2025-12-14 at 1 55 23 PM" src="https://github.com/user-attachments/assets/b3b9a76d-6b65-485c-9d8e-d86288498df3" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 00:21:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#48458
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?