[PR #19902] [MERGED] fix: Sync OAuth configs #48431

New Issue

GiteaMirror · 2026-04-30T00:18:07-05:00

GiteaMirror commented

2026-04-30 00:18:07 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/19902
Author: @taylorwilsdon
Created: 12/12/2025
Status: ✅ Merged
Merged: 12/14/2025
Merged by: @tjbck

Base: dev ← Head: sync_oauth_configs

📝 Commits (2)

0b5e64a ensure from config
65bca28 Merge branch 'dev' of github.com:taylorwilsdon/open-webui into sync_oauth_configs

📊 Changes

1 file changed (+49 additions, -2 deletions)

View changed files

📝 backend/open_webui/utils/oauth.py (+49 -2)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Ensure MCP OAuth 2.1 tool servers work across all nodes in multi-node deployments by lazily registering missing MCP OAuth clients from the shared config during authorize/callback, preventing 404s when the LB hits a node that didn’t process the original config update.

Added

Lazy load helper (ensure_client_from_config) in OAuthClientManager that reconstructs MCP OAuth clients from TOOL_SERVER_CONNECTIONS when absent on a given node.

Changed

OAuth authorize/callback handlers now attempt the lazy load before returning 404, aligning MCP OAuth client availability across nodes.

Deprecated

None.

Removed

None.

Fixed

Fixed MCP OAuth 2.1 streamable HTTP tool servers not propagating to all nodes; eliminated 404s on /oauth/clients/mcp:{id}/authorize/callback when hitting a node that lacked the in-memory registration.

Security

None.

Breaking Changes

BREAKING CHANGE: None.

Additional Information

No new dependencies; no docs changes needed.
[Attach any relevant screenshots or videos demonstrating the changes]

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/19902 **Author:** [@taylorwilsdon](https://github.com/taylorwilsdon) **Created:** 12/12/2025 **Status:** ✅ Merged **Merged:** 12/14/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `sync_oauth_configs` --- ### 📝 Commits (2) - [`0b5e64a`](https://github.com/open-webui/open-webui/commit/0b5e64aaa6af095e24d220a7e82dd0b1739887f6) ensure from config - [`65bca28`](https://github.com/open-webui/open-webui/commit/65bca283a760e36b4957837da1efb807373699f5) Merge branch 'dev' of github.com:taylorwilsdon/open-webui into sync_oauth_configs ### 📊 Changes **1 file changed** (+49 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/oauth.py` (+49 -2) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **Not targeting the `dev` branch will lead to immediate closure of the PR.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Take this as an opportunity to **make screenshots of the feature/fix and include it in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Ensure MCP OAuth 2.1 tool servers work across all nodes in multi-node deployments by lazily registering missing MCP OAuth clients from the shared config during authorize/callback, preventing 404s when the LB hits a node that didn’t process the original config update. ### Added - Lazy load helper (`ensure_client_from_config`) in `OAuthClientManager` that reconstructs MCP OAuth clients from `TOOL_SERVER_CONNECTIONS` when absent on a given node. ### Changed - OAuth authorize/callback handlers now attempt the lazy load before returning 404, aligning MCP OAuth client availability across nodes. ### Deprecated - None. ### Removed - None. ### Fixed - Fixed MCP OAuth 2.1 streamable HTTP tool servers not propagating to all nodes; eliminated 404s on `/oauth/clients/mcp:{id}/authorize`/callback when hitting a node that lacked the in-memory registration. ### Security - None. ### Breaking Changes - **BREAKING CHANGE**: None. --- ### Additional Information - No new dependencies; no docs changes needed. - [Attach any relevant screenshots or videos demonstrating the changes] ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-30 00:18:08 -05:00

GiteaMirror closed this issue

2026-04-30 00:18:12 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#48431