[PR #19687] [CLOSED] Fix embedding model update #48358

New Issue

GiteaMirror · 2026-04-30T00:04:50-05:00

GiteaMirror commented

2026-04-30 00:04:50 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/19687
Author: @rcivek
Created: 12/2/2025
Status: ❌ Closed

Base: dev ← Head: fix-embedding-model-update

📝 Commits (7)

fe6783c Merge pull request #19030 from open-webui/dev
fc05e0a Merge pull request #19405 from open-webui/dev
e3faec6 Merge pull request #19416 from open-webui/dev
9899293 Merge pull request #19448 from open-webui/dev
140605e Merge pull request #19462 from open-webui/dev
71f3d13 Fix: Use RAG_EMBEDDING_MODEL_AUTO_UPDATE when loading embedding model
cea0e6f Merge branch 'open-webui:main' into fix-embedding-model-update

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 backend/open_webui/routers/retrieval.py (+1 -0)

📄 Description

Summary

Fixes the embedding model update logic by correctly passing the auto_update flag to get_model_path, ensuring embedding models update properly when the auto-update setting is enabled.

Changes

Passed RAG_EMBEDDING_MODEL_AUTO_UPDATE to get_ef and get_model_path.
Ensured local_files_only reflects the actual auto-update setting.
Verified the embedding initialization logic works both online and offline.

🧪 Testing Confirmation

✅ I confirm that:

I have personally tested all changes included in this PR.
These changes work as intended and do not break existing functionality.

🔍 How I tested:

Enabled RAG_EMBEDDING_MODEL_AUTO_UPDATE=True.
Triggered an embedding model update through the UI.
Verified that get_model_path correctly used local_files_only=False and downloaded the model.
Disabled auto-update and confirmed local_files_only=True.
Confirmed embedding generation continues to work with existing engines (sentence-transformers, OpenAI, Ollama).

No visual evidence required, as this change is backend-only and produces no UI output.

📜 Contributor License Agreement

Open WebUI Contributor License Agreement

By submitting my contributions to Open WebUI, I grant Open WebUI full freedom to use my work in any way they choose, under any terms they like, both now and in the future. This approach helps ensure the project remains unified, flexible, and easy to maintain, while empowering Open WebUI to respond quickly to the needs of its users and the wider community.

Taking part in this process means my work can be seamlessly integrated and combined with others, ensuring longevity and adaptability for everyone who benefits from the Open WebUI project. This collaborative approach strengthens the project’s future and helps guarantee that improvements can always be shared and distributed in the most effective way possible.

To the fullest extent permitted by law, my contributions are provided on an “as is” basis, with no warranties or guarantees of any kind, and I disclaim any liability for any issues or damages arising from their use or incorporation into the project, regardless of the type of legal claim.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/19687 **Author:** [@rcivek](https://github.com/rcivek) **Created:** 12/2/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix-embedding-model-update` --- ### 📝 Commits (7) - [`fe6783c`](https://github.com/open-webui/open-webui/commit/fe6783c16699911c7be17392596d579333fb110c) Merge pull request #19030 from open-webui/dev - [`fc05e0a`](https://github.com/open-webui/open-webui/commit/fc05e0a6c5d39da60b603b4d520f800d6e36f748) Merge pull request #19405 from open-webui/dev - [`e3faec6`](https://github.com/open-webui/open-webui/commit/e3faec62c58e3a83d89aa3df539feacefa125e0c) Merge pull request #19416 from open-webui/dev - [`9899293`](https://github.com/open-webui/open-webui/commit/9899293f050ad50ae12024cbebee7e018acd851e) Merge pull request #19448 from open-webui/dev - [`140605e`](https://github.com/open-webui/open-webui/commit/140605e660b8186a7d5c79fb3be6ffb147a2f498) Merge pull request #19462 from open-webui/dev - [`71f3d13`](https://github.com/open-webui/open-webui/commit/71f3d131061fa560d49259f121d8c3ec664c60b0) Fix: Use RAG_EMBEDDING_MODEL_AUTO_UPDATE when loading embedding model - [`cea0e6f`](https://github.com/open-webui/open-webui/commit/cea0e6f1b4f1c5278ad2e3736e5686933bd97962) Merge branch 'open-webui:main' into fix-embedding-model-update ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/retrieval.py` (+1 -0) </details> ### 📄 Description ### Summary Fixes the embedding model update logic by correctly passing the `auto_update` flag to `get_model_path`, ensuring embedding models update properly when the auto-update setting is enabled. ### Changes - Passed `RAG_EMBEDDING_MODEL_AUTO_UPDATE` to `get_ef` and `get_model_path`. - Ensured `local_files_only` reflects the actual auto-update setting. - Verified the embedding initialization logic works both online and offline. --- ## 🧪 Testing Confirmation ### ✅ I confirm that: - I have personally tested all changes included in this PR. - These changes work as intended and do not break existing functionality. ### 🔍 How I tested: 1. Enabled `RAG_EMBEDDING_MODEL_AUTO_UPDATE=True`. 2. Triggered an embedding model update through the UI. 3. Verified that `get_model_path` correctly used `local_files_only=False` and downloaded the model. 4. Disabled auto-update and confirmed `local_files_only=True`. 5. Confirmed embedding generation continues to work with existing engines (sentence-transformers, OpenAI, Ollama). _No visual evidence required, as this change is backend-only and produces no UI output._ --- ## 📜 Contributor License Agreement # Open WebUI Contributor License Agreement By submitting my contributions to Open WebUI, I grant Open WebUI full freedom to use my work in any way they choose, under any terms they like, both now and in the future. This approach helps ensure the project remains unified, flexible, and easy to maintain, while empowering Open WebUI to respond quickly to the needs of its users and the wider community. Taking part in this process means my work can be seamlessly integrated and combined with others, ensuring longevity and adaptability for everyone who benefits from the Open WebUI project. This collaborative approach strengthens the project’s future and helps guarantee that improvements can always be shared and distributed in the most effective way possible. **_To the fullest extent permitted by law, my contributions are provided on an “as is” basis, with no warranties or guarantees of any kind, and I disclaim any liability for any issues or damages arising from their use or incorporation into the project, regardless of the type of legal claim._** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-30 00:04:50 -05:00

GiteaMirror closed this issue

2026-04-30 00:04:54 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#48358