[PR #18985] [CLOSED] fix: tool-calling await issue #48096

New Issue

GiteaMirror · 2026-04-29T23:36:34-05:00

GiteaMirror commented

2026-04-29 23:36:34 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/18985
Author: @kjpoccia
Created: 11/6/2025
Status: ❌ Closed

Base: dev ← Head: fix/tool-calling-await-issue

📝 Commits (3)

e85c7f7 Merge pull request #18402 from open-webui/dev
c5971a7 fix: await issue with tool-calling
a733b15 format

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 backend/open_webui/utils/middleware.py (+1 -1)
📝 backend/open_webui/utils/tools.py (+2 -2)

📄 Description

This is a fix for #18981 , we are seeing this too with all of our tool calls

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

🛠️ Native tool calling fix for unneeded await on a synchronously constructed tool wrapper. Made get_updated_tool_function synchronous and removed the unnecessary await at its call site, preventing coroutine mishandling that broke tool calls.

Description

Fix unneeded await in tool-calling path that caused tool execution issues when merging extra_params into tool functions. The fix makes get_updated_tool_function synchronous and removes an unnecessary await at the call site, aligning with how the wrapper function is constructed and returned.

Fixed

Corrects improper awaiting of a synchronously constructed function wrapper, which led to tool-call failures or incorrect coroutine handling during chat tool execution. Fixes #18981

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/18985 **Author:** [@kjpoccia](https://github.com/kjpoccia) **Created:** 11/6/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/tool-calling-await-issue` --- ### 📝 Commits (3) - [`e85c7f7`](https://github.com/open-webui/open-webui/commit/e85c7f79310f351672fe967a102396b6f3f5e88b) Merge pull request #18402 from open-webui/dev - [`c5971a7`](https://github.com/open-webui/open-webui/commit/c5971a760cdeff749bba62953156d47886c3f7e0) fix: await issue with tool-calling - [`a733b15`](https://github.com/open-webui/open-webui/commit/a733b15a7fc68ac8dccd36c3fdf8064b855fd12e) format ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/middleware.py` (+1 -1) 📝 `backend/open_webui/utils/tools.py` (+2 -2) </details> ### 📄 Description This is a fix for #18981 , we are seeing this too with all of our tool calls # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Verify that the pull request targets the `dev` branch. **Not targeting the `dev` branch will lead to immediate closure of the PR.** - [X] **Description:** Provide a concise description of the changes made in this pull request down below. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Take this as an opportunity to **make screenshots of the feature/fix and include it in the PR description**. - [X] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry - 🛠️ Native tool calling fix for unneeded await on a synchronously constructed tool wrapper. Made get_updated_tool_function synchronous and removed the unnecessary await at its call site, preventing coroutine mishandling that broke tool calls. ### Description Fix unneeded await in tool-calling path that caused tool execution issues when merging __extra_params__ into tool functions. The fix makes get_updated_tool_function synchronous and removes an unnecessary await at the call site, aligning with how the wrapper function is constructed and returned. ### Fixed - Corrects improper awaiting of a synchronously constructed function wrapper, which led to tool-call failures or incorrect coroutine handling during chat tool execution. Fixes #18981 --- ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-29 23:36:34 -05:00

GiteaMirror closed this issue

2026-04-29 23:36:36 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#48096