[PR #18710] [CLOSED] Fix: add database session sharing for PgBouncer compatibility #47938

New Issue

GiteaMirror · 2026-04-29T23:23:54-05:00

GiteaMirror commented

2026-04-29 23:23:54 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/18710
Author: @rahutami
Created: 10/29/2025
Status: ❌ Closed

Base: dev ← Head: pgbouncer-ssl-issue

📝 Commits (2)

02ebcd5 fix get functions, knowledge, prompt, tool, and model to reuse db session when doing user transaction
be140b3 add db param in get_users_by_user_ids

📊 Changes

6 files changed (+11 additions, -7 deletions)

View changed files

📝 backend/open_webui/models/functions.py (+1 -1)
📝 backend/open_webui/models/knowledge.py (+1 -1)
📝 backend/open_webui/models/models.py (+1 -1)
📝 backend/open_webui/models/prompts.py (+1 -1)
📝 backend/open_webui/models/tools.py (+1 -1)
📝 backend/open_webui/models/users.py (+6 -2)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch may lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code:: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review and manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This pull request is meant to fix an issue where I encounter SSL connection lost when trying to access the workspace page and function page in admin panel (Happens when there are existing items)
I've written the detail of the issue in this discussion thread #18709

Changed

Updated /backend/open_webui/models/users.py so that the get_users_by_user_ids accept db session in params and use it if passed
Updated these files so they pass existing db session to get_users_by_user_ids
- get_models in /backend/open_webui/models/models.py`
- get_knowledge_bases in /backend/open_webui/models/knowledge.py
- get_prompts in /backend/open_webui/models/prompts.py
- get_tools in /backend/open_webui/models/tools.py
- get_function_list in /backend/open_webui/models/functions.py

Fixed

Fixed an issue where workspace page and function page can't be opened when using a PostgreSQL with PgBouncer

Additional Information

I've tried using the updated code with SQLite and direct PostgreSQL and it created no error and it maintained the previous behavior

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/18710 **Author:** [@rahutami](https://github.com/rahutami) **Created:** 10/29/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `pgbouncer-ssl-issue` --- ### 📝 Commits (2) - [`02ebcd5`](https://github.com/open-webui/open-webui/commit/02ebcd58abed106d53f5786da66679ab14294e50) fix get functions, knowledge, prompt, tool, and model to reuse db session when doing user transaction - [`be140b3`](https://github.com/open-webui/open-webui/commit/be140b33552d95d870730086f6012723361ce033) add db param in get_users_by_user_ids ### 📊 Changes **6 files changed** (+11 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/models/functions.py` (+1 -1) 📝 `backend/open_webui/models/knowledge.py` (+1 -1) 📝 `backend/open_webui/models/models.py` (+1 -1) 📝 `backend/open_webui/models/prompts.py` (+1 -1) 📝 `backend/open_webui/models/tools.py` (+1 -1) 📝 `backend/open_webui/models/users.py` (+6 -2) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. Not targeting the `dev` branch may lead to immediate closure of the PR. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description. - [x] **Agentic AI Code:**: Confirm this Pull Request is **not written by any AI Agent** or has at least gone through additional human review **and** manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - This pull request is meant to fix an issue where I encounter SSL connection lost when trying to access the workspace page and function page in admin panel (Happens when there are existing items) - I've written the detail of the issue in this discussion thread #18709 ### Changed - Updated `/backend/open_webui/models/users.py` so that the `get_users_by_user_ids` accept db session in params and use it if passed - Updated these files so they pass existing db session to get_users_by_user_ids - `get_models` in /backend/open_webui/models/models.py` - `get_knowledge_bases` in `/backend/open_webui/models/knowledge.py` - `get_prompts` in `/backend/open_webui/models/prompts.py` - `get_tools` in `/backend/open_webui/models/tools.py` - `get_function_list` in `/backend/open_webui/models/functions.py` ### Fixed - Fixed an issue where workspace page and function page can't be opened when using a PostgreSQL with PgBouncer --- ### Additional Information - I've tried using the updated code with SQLite and direct PostgreSQL and it created no error and it maintained the previous behavior ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-29 23:23:54 -05:00

GiteaMirror closed this issue

2026-04-29 23:23:56 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#47938